gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc - Issue 2477673005: fix conformance2/textures/misc/tex-image-with-bad-args.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

Issue 2477673005: fix conformance2/textures/misc/tex-image-with-bad-args.html (Closed)

Patch Set: fix test CopyTexImage2DUnsizedInternalFormatES3 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

index 4392f9e8b4b141a53dfaf653e5404cadee6e4eaf..a784de8f2708ee126eec94c0af88801debc077a6 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

@@ -844,8 +844,7 @@ TEST_P(GLES2DecoderManualInitTest, CopyTexImage2DUnsizedInternalFormatES3) {

GLenum sized;

};

UnsizedSizedInternalFormat kUnsizedInternalFormats[] = {

- {GL_RED, GL_R8},

- {GL_RG, GL_RG8},

+ // GL_RED and GL_RG should not work.

{GL_RGB, GL_RGB8},

{GL_RGBA, GL_RGBA8},

{GL_BGRA_EXT, GL_RGBA8},