Don't fire onbeforeunload for same document history navigations with PlzNavigate.

Don't fire onbeforeunload for same document history navigations with PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
Committed: https://crrev.com/c226badf78042194290ba00f60ad24aeaf7417fc
Cr-Commit-Position: refs/heads/master@{#429760}

[jam, 2016-11-03 06:42:38]

Description was changed from

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
==========

to

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-11-03 06:42:42]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 06:43:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 07:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 07:41:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-11-03 15:33:54]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 15:34:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-11-03 15:37:03]

Patchset #2 (id:20001) has been deleted

[jam, 2016-11-03 15:37:03]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 15:37:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-11-03 17:01:12]

jam@chromium.org changed reviewers:
+ creis@chromium.org

[commit-bot: I haz the power, 2016-11-03 17:55:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 17:55:56]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Charlie Reis, 2016-11-03 21:05:47]

Thanks, LGTM.

https://codereview.chromium.org/2477623002/diff/40001/content/test/test_rende...
File content/test/test_render_frame_host.cc (right):

https://codereview.chromium.org/2477623002/diff/40001/content/test/test_rende...
content/test/test_render_frame_host.cc:332: params.document_sequence_number =
++s_document_sequence_number;
This is probably ok, but you could set it to the item_sequence_number + 1 to be
more representative of what happens in practice, if you want.

[jam, 2016-11-03 21:12:20]

https://codereview.chromium.org/2477623002/diff/40001/content/test/test_rende...
File content/test/test_render_frame_host.cc (right):

https://codereview.chromium.org/2477623002/diff/40001/content/test/test_rende...
content/test/test_render_frame_host.cc:332: params.document_sequence_number =
++s_document_sequence_number;
On 2016/11/03 21:05:47, Charlie Reis wrote:
> This is probably ok, but you could set it to the item_sequence_number + 1 to
be
> more representative of what happens in practice, if you want.

Thanks, sure.

[jam, 2016-11-03 21:13:34]

The CQ bit was checked by jam@chromium.org

[jam, 2016-11-03 21:13:35]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2477623002/#ps60001
(title: "review comment")

[commit-bot: I haz the power, 2016-11-03 21:14:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:44:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-11-03 23:00:09]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:01:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-11-04 01:29:53]

Description was changed from

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
==========

[jam, 2016-11-04 01:30:01]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-11-04 01:30:09]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 01:43:43]

Description was changed from

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
==========

to

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
==========

[commit-bot: I haz the power, 2016-11-04 01:43:46]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-04 01:45:11]

Description was changed from

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347
==========

to

==========
Don't fire onbeforeunload for same document history navigations with
PlzNavigate.

This fixes
OptionsWebUIExtendedTest.OverlayBackToChild
with PlzNavigate.

BUG=504347

Committed: https://crrev.com/c226badf78042194290ba00f60ad24aeaf7417fc
Cr-Commit-Position: refs/heads/master@{#429760}
==========

[commit-bot: I haz the power, 2016-11-04 01:45:12]

Patchset 3 (id:??) landed as
https://crrev.com/c226badf78042194290ba00f60ad24aeaf7417fc
Cr-Commit-Position: refs/heads/master@{#429760}