Don't fire onbeforeunload for same document history navigations with PlzNavigate.

content/test/test_render_frame_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/test_render_frame_host.h"
 
 #include "base/guid.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/navigation_handle_impl.h"
 #include "content/browser/frame_host/navigation_request.h"
@@ skipping 307 matching lines @@
   params.should_replace_current_entry = should_replace_entry;
   params.gesture = NavigationGestureUser;
   params.contents_mime_type = contents_mime_type_;
   params.method = "GET";
   params.http_status_code = response_code;
   params.socket_address.set_host("2001:db8::1");
   params.socket_address.set_port(80);
   params.history_list_was_cleared = simulate_history_list_was_cleared_;
   params.original_request_url = url_copy;
 
-  // Simulate Blink assigning an item sequence number to the navigation.
+  // Simulate Blink assigning an item and document sequence number to the
+  // navigation.
   params.item_sequence_number = base::Time::Now().ToDoubleT() * 1000000;
+  static int s_document_sequence_number = 0;
+  params.document_sequence_number = ++s_document_sequence_number;

[Charlie Reis, 2016/11/03 21:05:47]

This is probably ok, but you could set it to the item_sequence_number + 1 to be
more representative of what happens in practice, if you want.

[jam, 2016/11/03 21:12:20]

Thanks, sure.

 
   // When the user hits enter in the Omnibox without changing the URL, Blink
   // behaves similarly to a reload and does not change the item and document
   // sequence numbers. Simulate this behavior here too.
   if (transition == ui::PAGE_TRANSITION_TYPED) {
     const NavigationEntryImpl* entry =
         static_cast<NavigationEntryImpl*>(frame_tree_node()
                                               ->navigator()
                                               ->GetController()
                                               ->GetLastCommittedEntry());
@@ skipping 21 matching lines @@
   // same page is not robust, as it will not handle pushState type navigation.
   // Do not use elsewhere!
   params.was_within_same_page =
       !ui::PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_RELOAD) &&
       !ui::PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_TYPED) &&
       (GetLastCommittedURL().is_valid() && !last_commit_was_error_page_ &&
        url_copy.ReplaceComponents(replacements) ==
            GetLastCommittedURL().ReplaceComponents(replacements));
 
   params.page_state =
-      PageState::CreateForTesting(url_copy, false, nullptr, nullptr);
+      PageState::CreateForTestingWithSequenceNumbers(
+          url_copy, params.item_sequence_number,
+          params.document_sequence_number);
 
   if (!callback.is_null())
     callback.Run(&params);
 
   SendNavigateWithParams(&params);
 }
 
 void TestRenderFrameHost::SendNavigateWithParams(
     FrameHostMsg_DidCommitProvisionalLoad_Params* params) {
   FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), *params);
@@ skipping 95 matching lines @@
   // PlzNavigate: NavigationHandle::WillStartRequest has already been called at
   // this point.
   if (!navigation_handle() || IsBrowserSideNavigationEnabled())
     return;
   navigation_handle()->CallWillStartRequestForTesting(
       false /* is_post */, Referrer(GURL(), blink::WebReferrerPolicyDefault),
       true /* user_gesture */, transition, false /* is_external_protocol */);
 }
 
 }  // namespace content