Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2477513002: Fix Java weak reference nullification in MediaSessionAndroid (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 1 month ago
Reviewers:
boliu
CC:
chromium-reviews, jam, lizeb+watch-custom-tabs_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Java weak reference nullification in MediaSessionAndroid This CL fixes a Java weak reference nullification issue which happens when a garbage collection is run between garbage collecting Java WebContents and MediaSessionAndroid destruction. MediaSessionAndroid should always unset the Java weak reference when receiving MediaSessionDestroyed(). This CL also re-enables a flaky test disabled previously due to this issue. BUG=661444 TBR=tedchoc@chromium.org Committed: https://crrev.com/05e950493073776c3f1817cbe11df728c04ebeae Cr-Commit-Position: refs/heads/master@{#429476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/media/session/media_session_android.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Zhiqiang Zhang (Slow)
PTAL! Thanks for pointing out the issue :)
4 years, 1 month ago (2016-11-02 23:33:56 UTC) #3
boliu
lgtm
4 years, 1 month ago (2016-11-02 23:39:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477513002/1
4 years, 1 month ago (2016-11-02 23:44:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 00:33:32 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 00:36:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05e950493073776c3f1817cbe11df728c04ebeae
Cr-Commit-Position: refs/heads/master@{#429476}

Powered by Google App Engine
This is Rietveld 408576698