Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: content/browser/media/session/media_session_android.cc

Issue 2477513002: Fix Java weak reference nullification in MediaSessionAndroid (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/session/media_session_android.h" 5 #include "content/browser/media/session/media_session_android.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include "content/browser/media/session/media_session_impl.h" 8 #include "content/browser/media/session/media_session_impl.h"
9 #include "content/browser/web_contents/web_contents_android.h" 9 #include "content/browser/web_contents/web_contents_android.h"
10 #include "content/browser/web_contents/web_contents_impl.h" 10 #include "content/browser/web_contents/web_contents_impl.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 return ScopedJavaLocalRef<jobject>(); 56 return ScopedJavaLocalRef<jobject>();
57 57
58 MediaSessionImpl* session = MediaSessionImpl::Get(contents); 58 MediaSessionImpl* session = MediaSessionImpl::Get(contents);
59 DCHECK(session); 59 DCHECK(session);
60 return MediaSessionAndroid::JavaObjectGetter::GetJavaObject( 60 return MediaSessionAndroid::JavaObjectGetter::GetJavaObject(
61 session->session_android()); 61 session->session_android());
62 } 62 }
63 63
64 void MediaSessionAndroid::MediaSessionDestroyed() { 64 void MediaSessionAndroid::MediaSessionDestroyed() {
65 ScopedJavaLocalRef<jobject> j_local_session = GetJavaObject(); 65 ScopedJavaLocalRef<jobject> j_local_session = GetJavaObject();
66 if (j_local_session.is_null()) 66 if (j_local_session.is_null()) {
67 // If the Java MediaSession is already garbage collected, unset the weak
68 // Java reference.
69 j_media_session_.reset();
67 return; 70 return;
71 }
68 72
69 JNIEnv* env = base::android::AttachCurrentThread(); 73 JNIEnv* env = base::android::AttachCurrentThread();
70 // The Java object will tear down after this call. 74 // The Java object will tear down after this call.
71 Java_MediaSessionImpl_mediaSessionDestroyed(env, j_local_session); 75 Java_MediaSessionImpl_mediaSessionDestroyed(env, j_local_session);
72 j_media_session_.reset(); 76 j_media_session_.reset();
73 77
74 WebContentsAndroid* contents_android = GetWebContentsAndroid(); 78 WebContentsAndroid* contents_android = GetWebContentsAndroid();
75 if (contents_android) 79 if (contents_android)
76 contents_android->SetMediaSession(nullptr); 80 contents_android->SetMediaSession(nullptr);
77 } 81 }
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 return nullptr; 141 return nullptr;
138 return contents->GetWebContentsAndroid(); 142 return contents->GetWebContentsAndroid();
139 } 143 }
140 144
141 ScopedJavaLocalRef<jobject> MediaSessionAndroid::GetJavaObject() { 145 ScopedJavaLocalRef<jobject> MediaSessionAndroid::GetJavaObject() {
142 JNIEnv* env = base::android::AttachCurrentThread(); 146 JNIEnv* env = base::android::AttachCurrentThread();
143 return j_media_session_.get(env); 147 return j_media_session_.get(env);
144 } 148 }
145 149
146 } // namespace content 150 } // namespace content
OLDNEW
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698