MD Settings: Sync route paths in JavaScript to URL constants in C++

MD Settings: Sync route paths in JavaScript to URL constants in C++

This tries to prevent further legacy-URL breakages by explicitly linking
URL constants in C++ to route declarations in JavaScript.

BUG=661694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[tommycli, 2016-11-02 22:12:34]

Description was changed from

==========
MD Settings: Sync route paths in JavaScript to URL constants in C++

This tries to prevent further legacy-URL breakages by explicitly linking
URL constants in C++ to route declarations in JavaScript.

BUG=661694
==========

to

==========
MD Settings: Sync route paths in JavaScript to URL constants in C++

This tries to prevent further legacy-URL breakages by explicitly linking
URL constants in C++ to route declarations in JavaScript.

BUG=661694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-02 22:12:37]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 22:13:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:26:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:26:52]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[tommycli, 2016-11-02 22:33:56]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-11-02 22:33:57]

dbeam: PTAL

I think this patch is a narrow win. It prevents some breakages at the cost of
extra complexity... eh.. I could go either way with sending it in or not. Let me
know.

Tommy

[tommycli, 2016-11-02 22:34:40]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 22:35:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-02 22:57:18]

i don't think it's worth all these keys

can we make a routes dictionary?

var p = loadTimeData.getValue('paths');

r.INTERNET = r.BASIC.createSection(p.INTERNET);

[Dan Beam, 2016-11-02 22:58:19]

On 2016/11/02 22:33:57, tommycli wrote:
> dbeam: PTAL
> 
> I think this patch is a narrow win. It prevents some breakages at the cost of
> extra complexity... eh.. I could go either way with sending it in or not. Let
me
> know.
> 
> Tommy

i also agree

[tommycli, 2016-11-02 23:11:37]

On 2016/11/02 22:57:18, Dan Beam wrote:
> i don't think it's worth all these keys
> 
> can we make a routes dictionary?
> 
> var p = loadTimeData.getValue('paths');
> 
> r.INTERNET = r.BASIC.createSection(p.INTERNET);

Unfortunately that loses the runtime assertions of loadTimeData if we fatfinger
a path name. And also closure compile fails.

[commit-bot: I haz the power, 2016-11-03 01:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:15:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-11-05 00:51:29]

On 2016/11/02 23:11:37, tommycli wrote:
> On 2016/11/02 22:57:18, Dan Beam wrote:
> > i don't think it's worth all these keys
> > 
> > can we make a routes dictionary?
> > 
> > var p = loadTimeData.getValue('paths');
> > 
> > r.INTERNET = r.BASIC.createSection(p.INTERNET);
> 
> Unfortunately that loses the runtime assertions of loadTimeData if we
fatfinger
> a path name. And also closure compile fails.

we need a system of compile-time JS and C++ type generation for map<enum,
string>.  maybe we could use an .idl in extensions?

[michaelpg, 2016-11-05 01:37:19]

On 2016/11/02 23:11:37, tommycli wrote:
> On 2016/11/02 22:57:18, Dan Beam wrote:
> > i don't think it's worth all these keys
> > 
> > can we make a routes dictionary?
> > 
> > var p = loadTimeData.getValue('paths');
> > 
> > r.INTERNET = r.BASIC.createSection(p.INTERNET);
> 
> Unfortunately that loses the runtime assertions of loadTimeData if we
fatfinger
> a path name. And also closure compile fails.

can we just move the run-time checking to createChild?

r.INTERNET = r.BASIC.createSection('internet');