Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3655)

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2477453002: MD Settings: Sync route paths in JavaScript to URL constants in C++ (Closed)
Patch Set: fix js compile Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/route.js
diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js
index d90cbfa73d0ce6e46f40839ac27f1b11fcea9df4..98f0a9e1a1eda65b2c7af3efe45fe7fec9f6fa6a 100644
--- a/chrome/browser/resources/settings/route.js
+++ b/chrome/browser/resources/settings/route.js
@@ -93,14 +93,17 @@ cr.define('settings', function() {
// Navigable dialogs. These are the only non-section children of root pages.
// These are disfavored. If we add anymore, we should add explicit support.
- r.SIGN_OUT = r.BASIC.createChild('/signOut');
- r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild('/clearBrowserData');
- r.RESET_DIALOG = r.ADVANCED.createChild('/resetProfileSettings');
- r.TRIGGERED_RESET_DIALOG =
- r.ADVANCED.createChild('/triggeredResetProfileSettings');
+ r.SIGN_OUT = r.BASIC.createChild(loadTimeData.getString('signOutPath'));
+ r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild(
+ loadTimeData.getString('clearBrowserDataPath'));
+ r.RESET_DIALOG = r.ADVANCED.createChild(
+ loadTimeData.getString('resetProfileSettingsPath'));
+ r.TRIGGERED_RESET_DIALOG = r.ADVANCED.createChild(
+ loadTimeData.getString('triggeredResetProfileSettingsPath'));
<if expr="chromeos">
- r.INTERNET = r.BASIC.createSection('/internet', 'internet');
+ r.INTERNET = r.BASIC.createSection(
+ loadTimeData.getString('internetPath'), 'internet');
r.NETWORK_DETAIL = r.INTERNET.createChild('/networkDetail');
r.KNOWN_NETWORKS = r.INTERNET.createChild('/knownNetworks');
</if>
@@ -112,14 +115,16 @@ cr.define('settings', function() {
r.BASIC.createSection('/defaultBrowser', 'defaultBrowser');
r.SEARCH = r.BASIC.createSection('/search', 'search');
- r.SEARCH_ENGINES = r.SEARCH.createChild('/searchEngines');
+ r.SEARCH_ENGINES =
+ r.SEARCH.createChild(loadTimeData.getString('searchEnginesPath'));
r.ON_STARTUP = r.BASIC.createSection('/onStartup', 'onStartup');
r.PEOPLE = r.BASIC.createSection('/people', 'people');
- r.SYNC = r.PEOPLE.createChild('/syncSetup');
+ r.SYNC = r.PEOPLE.createChild(loadTimeData.getString('syncSetupPath'));
<if expr="not chromeos">
- r.MANAGE_PROFILE = r.PEOPLE.createChild('/manageProfile');
+ r.MANAGE_PROFILE =
+ r.PEOPLE.createChild(loadTimeData.getString('manageProfilePath'));
</if>
<if expr="chromeos">
r.CHANGE_PICTURE = r.PEOPLE.createChild('/changePicture');
@@ -137,12 +142,14 @@ cr.define('settings', function() {
r.PRIVACY = r.ADVANCED.createSection('/privacy', 'privacy');
r.CERTIFICATES = r.PRIVACY.createChild('/certificates');
- r.SITE_SETTINGS = r.PRIVACY.createChild('/content');
+ r.SITE_SETTINGS =
+ r.PRIVACY.createChild(loadTimeData.getString('contentPath'));
r.SITE_SETTINGS_ALL = r.SITE_SETTINGS.createChild('all');
- r.SITE_SETTINGS_SITE_DETAILS =
- r.SITE_SETTINGS_ALL.createChild('/content/siteDetails');
+ r.SITE_SETTINGS_SITE_DETAILS = r.SITE_SETTINGS_ALL.createChild(
+ loadTimeData.getString('contentPath') + '/siteDetails');
- r.SITE_SETTINGS_HANDLERS = r.SITE_SETTINGS.createChild('/handlers');
+ r.SITE_SETTINGS_HANDLERS = r.SITE_SETTINGS.createChild(
+ loadTimeData.getString('handlersPath'));
// TODO(tommycli): Find a way to refactor these repetitive category routes.
r.SITE_SETTINGS_AUTOMATIC_DOWNLOADS =
@@ -167,16 +174,20 @@ cr.define('settings', function() {
r.SITE_SETTINGS_ZOOM_LEVELS = r.SITE_SETTINGS.createChild('zoomLevels');
<if expr="chromeos">
- r.DATETIME = r.ADVANCED.createSection('/dateTime', 'dateTime');
- r.BLUETOOTH = r.ADVANCED.createSection('/bluetooth', 'bluetooth');
+ r.DATETIME = r.ADVANCED.createSection(
+ loadTimeData.getString('dateTimePath'), 'dateTime');
+ r.BLUETOOTH = r.ADVANCED.createSection(
+ loadTimeData.getString('bluetoothPath'), 'bluetooth');
</if>
r.PASSWORDS =
r.ADVANCED.createSection('/passwordsAndForms', 'passwordsAndForms');
- r.AUTOFILL = r.PASSWORDS.createChild('/autofill');
- r.MANAGE_PASSWORDS = r.PASSWORDS.createChild('/passwords');
+ r.AUTOFILL = r.PASSWORDS.createChild(loadTimeData.getString('autofillPath'));
+ r.MANAGE_PASSWORDS =
+ r.PASSWORDS.createChild(loadTimeData.getString('passwordsPath'));
- r.LANGUAGES = r.ADVANCED.createSection('/languages', 'languages');
+ r.LANGUAGES = r.ADVANCED.createSection(
+ loadTimeData.getString('languagesPath'), 'languages');
<if expr="chromeos">
r.INPUT_METHODS = r.LANGUAGES.createChild('/inputMethods');
</if>
@@ -193,7 +204,8 @@ cr.define('settings', function() {
r.CUPS_PRINTER_DETAIL = r.CUPS_PRINTERS.createChild('/cupsPrinterDetails');
</if>
- r.ACCESSIBILITY = r.ADVANCED.createSection('/accessibility', 'a11y');
+ r.ACCESSIBILITY = r.ADVANCED.createSection(
+ loadTimeData.getString('accessibilityPath'), 'a11y');
r.MANAGE_ACCESSIBILITY = r.ACCESSIBILITY.createChild('/manageAccessibility');
r.SYSTEM = r.ADVANCED.createSection('/system', 'system');

Powered by Google App Engine
This is Rietveld 408576698