appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py - Issue 2477343003: [Findit] Refactoring monitor swarming task pipelines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

Issue 2477343003: [Findit] Refactoring monitor swarming task pipelines (Closed)

Patch Set: Addressing comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py ('k') | appengine/findit/waterfall/process_swarming_task_result_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

diff --git a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

index e89ae89c12c9a887983b74cb0512d5204f0bb8c2..e2ff6427b454536872af750368688248df23646f 100644

--- a/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

+++ b/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

@@ -102,8 +102,9 @@ class ProcessFlakeSwarmingTaskResultPipeline(

master_build_number, test_name, version_number)

# Unused Argument - pylint: disable=W0612,W0613

+ # Arguments number differs from overridden method - pylint: disable=W0221

def _GetSwarmingTask(self, master_name, builder_name, build_number,

step_name, master_build_number, test_name, _):

- # Get the appropriate kind of Swarming Task (Flake).

- return FlakeSwarmingTask.Get(master_name, builder_name,

- build_number, step_name, test_name)

+ # Gets the appropriate kind of swarming task (FlakeSwarmingTask).

+ return FlakeSwarmingTask.Get(master_name, builder_name, build_number,

+ step_name, test_name)