[Findit] Refactoring monitor swarming task pipelines

appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from collections import defaultdict
 
 from model.flake.flake_swarming_task import FlakeSwarmingTask
 from model.flake.master_flake_analysis import DataPoint
@@ skipping 35 matching lines @@
 
     tests_statuses = defaultdict(lambda: defaultdict(int))
 
     if not output_json:
       return tests_statuses
 
     for iteration in output_json.get('per_iteration_data'):
       for name, test_runs in iteration.iteritems():
         tests_statuses[name]['total_run'] += len(test_runs)
         for test_run in test_runs:
           tests_statuses[name][test_run['status']] += 1

[chanli, 2016/11/09 04:28:28]

Until here the function for flake-swarms and waterfall-swarms are the same,
maybe we can move this part to the base class and use inheritance here?

[lijeffrey, 2016/11/09 10:18:10]

Done.

 
     # Should query by test name, because some test has dependencies which
     # are also run, like TEST and PRE_TEST in browser_tests.
     tries = tests_statuses.get(test_name, {}).get('total_run', 0)
     successes = tests_statuses.get(test_name, {}).get('SUCCESS', 0)
 
     if tries > 0:
       pass_rate = successes * 1.0 / tries
     else:
       pass_rate = -1  # Special value to indicate test is not existing.
@@ skipping 28 matching lines @@
 
   def _GetArgs(self, master_name, builder_name, build_number,
                step_name, *args):
     master_build_number = args[0]
     test_name = args[1]
     version_number = args[2]
     return (master_name, builder_name, build_number, step_name,
             master_build_number, test_name, version_number)
 
   # Unused Argument - pylint: disable=W0612,W0613
+  # Arguments number differs from overridden method - pylint: disable=W0221
   def _GetSwarmingTask(self, master_name, builder_name, build_number,
                        step_name, master_build_number, test_name, _):
-    # Get the appropriate kind of Swarming Task (Flake).
-    return FlakeSwarmingTask.Get(master_name, builder_name,
-                                 build_number, step_name, test_name)
+    # Gets the appropriate kind of swarming task (FlakeSwarmingTask).
+    return FlakeSwarmingTask.Get(master_name, builder_name, build_number,
+                                 step_name, test_name)