Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5334)

Unified Diff: chrome/service/service_utility_process_host.h

Issue 2477283002: Convert printing IPCs to Mojo
Patch Set: git cl format Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/service_utility_process_host.h
diff --git a/chrome/service/service_utility_process_host.h b/chrome/service/service_utility_process_host.h
index d0dea943390b3ed589ba630b6f10b157eb11a85b..c43de472f7c55c253d10a6f6d89f5194b1d54550 100644
--- a/chrome/service/service_utility_process_host.h
+++ b/chrome/service/service_utility_process_host.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
+#include "components/printing/common/printing.mojom.h"
#include "content/public/common/child_process_host_delegate.h"
#include "ipc/ipc_platform_file.h"
@@ -106,8 +107,6 @@ class ServiceUtilityProcessHost : public content::ChildProcessHostDelegate {
bool StartGetPrinterSemanticCapsAndDefaults(const std::string& printer_name);
protected:
- bool Send(IPC::Message* msg);
-
// Allows this method to be overridden for tests.
virtual base::FilePath GetUtilityProcessCmd();
@@ -116,6 +115,9 @@ class ServiceUtilityProcessHost : public content::ChildProcessHostDelegate {
bool OnMessageReceived(const IPC::Message& message) override;
const base::Process& GetProcess() const override;
+ printing::mojom::Printing* printing();
+ printing::mojom::PrintingPtr printing_;
Sam McNally 2016/12/12 06:09:20 Why is this protected?
tibell 2016/12/13 23:41:55 Done.
+
private:
// Starts a process. Returns true iff it succeeded.
bool StartProcess(bool no_sandbox);
@@ -131,15 +133,14 @@ class ServiceUtilityProcessHost : public content::ChildProcessHostDelegate {
// Messages handlers:
void OnRenderPDFPagesToMetafilesPageCount(int page_count);
void OnRenderPDFPagesToMetafilesPageDone(bool success, float scale_factor);
- void OnGetPrinterCapsAndDefaultsSucceeded(
+ void OnGetPrinterCapsAndDefaults(
const std::string& printer_name,
- const printing::PrinterCapsAndDefaults& caps_and_defaults);
- void OnGetPrinterCapsAndDefaultsFailed(const std::string& printer_name);
- void OnGetPrinterSemanticCapsAndDefaultsSucceeded(
+ const base::Optional<printing::PrinterCapsAndDefaults>&
+ caps_and_defaults);
+ void OnGetPrinterSemanticCapsAndDefaults(
const std::string& printer_name,
- const printing::PrinterSemanticCapsAndDefaults& caps_and_defaults);
- void OnGetPrinterSemanticCapsAndDefaultsFailed(
- const std::string& printer_name);
+ const base::Optional<printing::PrinterSemanticCapsAndDefaults>&
+ caps_and_defaults);
std::unique_ptr<content::ChildProcessHost> child_process_host_;
base::Process process_;

Powered by Google App Engine
This is Rietveld 408576698