Convert printing IPCs to Mojo

chrome/service/service_utility_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_
 #define CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
+#include "components/printing/common/printing.mojom.h"
 #include "content/public/common/child_process_host_delegate.h"
 #include "ipc/ipc_platform_file.h"
 
 namespace base {
 class CommandLine;
 class File;
 class FilePath;
 class SingleThreadTaskRunner;
 }  // namespace base
 
@@ skipping 75 matching lines @@
   // in a sandbox.
   bool StartGetPrinterCapsAndDefaults(const std::string& printer_name);
 
   // Starts a process to get capabilities and defaults for the specified
   // printer. Used on Windows to isolate the service process from printer driver
   // crashes by executing this in a separate process. The process does not run
   // in a sandbox. Returns result as printing::PrinterSemanticCapsAndDefaults.
   bool StartGetPrinterSemanticCapsAndDefaults(const std::string& printer_name);
 
  protected:
-  bool Send(IPC::Message* msg);
-
   // Allows this method to be overridden for tests.
   virtual base::FilePath GetUtilityProcessCmd();
 
   // ChildProcessHostDelegate implementation:
   void OnChildDisconnected() override;
   bool OnMessageReceived(const IPC::Message& message) override;
   const base::Process& GetProcess() const override;
 
+  printing::mojom::Printing* printing();
+  printing::mojom::PrintingPtr printing_;

[Sam McNally, 2016/12/12 06:09:20]

Why is this protected?

[tibell, 2016/12/13 23:41:55]

Done.

+
  private:
   // Starts a process.  Returns true iff it succeeded.
   bool StartProcess(bool no_sandbox);
 
   // Launch the child process synchronously.
   bool Launch(base::CommandLine* cmd_line, bool no_sandbox);
 
   base::ProcessHandle handle() const { return process_.Handle(); }
 
   void OnMetafileSpooled(bool success);
   void OnPDFToEmfFinished(bool success);
 
   // Messages handlers:
   void OnRenderPDFPagesToMetafilesPageCount(int page_count);
   void OnRenderPDFPagesToMetafilesPageDone(bool success, float scale_factor);
-  void OnGetPrinterCapsAndDefaultsSucceeded(
+  void OnGetPrinterCapsAndDefaults(
       const std::string& printer_name,
-      const printing::PrinterCapsAndDefaults& caps_and_defaults);
-  void OnGetPrinterCapsAndDefaultsFailed(const std::string& printer_name);
-  void OnGetPrinterSemanticCapsAndDefaultsSucceeded(
+      const base::Optional<printing::PrinterCapsAndDefaults>&
+          caps_and_defaults);
+  void OnGetPrinterSemanticCapsAndDefaults(
       const std::string& printer_name,
-      const printing::PrinterSemanticCapsAndDefaults& caps_and_defaults);
-  void OnGetPrinterSemanticCapsAndDefaultsFailed(
-      const std::string& printer_name);
+      const base::Optional<printing::PrinterSemanticCapsAndDefaults>&
+          caps_and_defaults);
 
   std::unique_ptr<content::ChildProcessHost> child_process_host_;
   base::Process process_;
   // A pointer to our client interface, who will be informed of progress.
   scoped_refptr<Client> client_;
   scoped_refptr<base::SingleThreadTaskRunner> client_task_runner_;
   bool waiting_for_reply_;
   const std::string mojo_child_token_;
 
   // Start time of operation.
   base::Time start_time_;
 
   class PdfToEmfState;
   std::unique_ptr<PdfToEmfState> pdf_to_emf_state_;
 
   base::WeakPtrFactory<ServiceUtilityProcessHost> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceUtilityProcessHost);
 };
 
 #endif  // CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_