Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2477093002: fix #27766, allow implicit casts from dynamic to composite types (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27766, allow implicit casts from dynamic to composite types R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/43bcc5945ef9776f36c73825043934d774b76dc4

Patch Set 1 #

Patch Set 2 : add changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M CHANGELOG.md View 1 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
it's not breaking but maybe this is worth a changelog entry?
4 years, 1 month ago (2016-11-04 23:52:00 UTC) #2
Leaf
lgtm. Yes, worth a CHANGELOG entry.
4 years, 1 month ago (2016-11-05 00:01:28 UTC) #3
Jennifer Messerly
Done! thanks :)
4 years, 1 month ago (2016-11-05 00:35:24 UTC) #4
Jennifer Messerly
4 years, 1 month ago (2016-11-05 00:37:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
43bcc5945ef9776f36c73825043934d774b76dc4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698