pkg/analyzer/lib/src/task/strong/checker.dart - Issue 2477093002: fix #27766, allow implicit casts from dynamic to composite types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/strong/checker.dart

Issue 2477093002: fix #27766, allow implicit casts from dynamic to composite types (Closed)

Patch Set: add changelog Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/strong/checker.dart

diff --git a/pkg/analyzer/lib/src/task/strong/checker.dart b/pkg/analyzer/lib/src/task/strong/checker.dart

index b32ff6e515e26aa2b913ea66939586deaee448f5..453f14c142aa2a0dc6841c0ec27e7f1f91175fd6 100644

--- a/pkg/analyzer/lib/src/task/strong/checker.dart

+++ b/pkg/analyzer/lib/src/task/strong/checker.dart

@@ -1088,7 +1088,7 @@ class CodeChecker extends RecursiveAstVisitor {

downCastComposite =

typeArgs.isEmpty || typeArgs.any((t) => t.isDynamic);

} else {

- downCastComposite = true;

+ downCastComposite = !from.isDynamic;

}

« no previous file with comments | « CHANGELOG.md ('k') | pkg/analyzer/test/src/task/strong/checker_test.dart » ('j') | no next file with comments »