Pass object to ReplaceIndirectObjectIfHigherGeneration() by unique_ptr.

core/fpdfapi/parser/cfdf_document.cpp

Index: core/fpdfapi/parser/cfdf_document.cpp
diff --git a/core/fpdfapi/parser/cfdf_document.cpp b/core/fpdfapi/parser/cfdf_document.cpp
index e66bfeb12b30be63f2b48235011d57c338941fb6..a0f3e1490daa16c12ddeba85e4ac98fc9cf83daf 100644
--- a/core/fpdfapi/parser/cfdf_document.cpp
+++ b/core/fpdfapi/parser/cfdf_document.cpp
@@ -69,11 +69,12 @@ void CFDF_Document::ParseStream(IFX_SeekableReadStream* pFile, bool bOwnFile) {
       if (word != "obj")
         break;
 
-      CPDF_Object* pObj = parser.GetObject(this, objnum, 0, true);
+      auto pObj = pdfium::WrapUnique<CPDF_Object>(

[Lei Zhang, 2016/11/04 22:04:36]

Would love it if CPDF_SyntaxParser::GetObject() can return an unique_ptr.

[Tom Sepez, 2016/11/04 22:44:03]

To do as a followup. This is an interim step. The ripples spread pretty far when
that change is made.

[Lei Zhang, 2016/11/04 22:48:53]

Sure. I wasn't suggesting doing it here.

+          parser.GetObject(this, objnum, 0, true));
       if (!pObj)
         break;
 
-      ReplaceIndirectObjectIfHigherGeneration(objnum, pObj);
+      ReplaceIndirectObjectIfHigherGeneration(objnum, std::move(pObj));
       word = parser.GetNextWord(nullptr);
       if (word != "endobj")
         break;