Pass object to ReplaceIndirectObjectIfHigherGeneration() by unique_ptr.

core/fpdfapi/parser/cfdf_document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/parser/cfdf_document.h"
 
 #include "core/fpdfapi/edit/cpdf_creator.h"
 #include "core/fpdfapi/parser/cpdf_dictionary.h"
@@ skipping 51 matching lines @@
         break;
 
       word = parser.GetNextWord(&bNumber);
       if (!bNumber)
         break;
 
       word = parser.GetNextWord(nullptr);
       if (word != "obj")
         break;
 
-      CPDF_Object* pObj = parser.GetObject(this, objnum, 0, true);
+      auto pObj = pdfium::WrapUnique<CPDF_Object>(

[Lei Zhang, 2016/11/04 22:04:36]

Would love it if CPDF_SyntaxParser::GetObject() can return an unique_ptr.

[Tom Sepez, 2016/11/04 22:44:03]

To do as a followup. This is an interim step. The ripples spread pretty far when
that change is made.

[Lei Zhang, 2016/11/04 22:48:53]

Sure. I wasn't suggesting doing it here.

+          parser.GetObject(this, objnum, 0, true));
       if (!pObj)
         break;
 
-      ReplaceIndirectObjectIfHigherGeneration(objnum, pObj);
+      ReplaceIndirectObjectIfHigherGeneration(objnum, std::move(pObj));
       word = parser.GetNextWord(nullptr);
       if (word != "endobj")
         break;
     } else {
       if (word != "trailer")
         break;
 
       if (CPDF_Dictionary* pMainDict =
               ToDictionary(parser.GetObject(this, 0, 0, true))) {
         m_pRootDict = pMainDict->GetDictFor("Root");
@@ skipping 10 matching lines @@
 
   buf << "%FDF-1.2\r\n";
   for (const auto& pair : *this)
     buf << pair.first << " 0 obj\r\n"
         << pair.second.get() << "\r\nendobj\r\n\r\n";
 
   buf << "trailer\r\n<</Root " << m_pRootDict->GetObjNum()
       << " 0 R>>\r\n%%EOF\r\n";
   return true;
 }