Revert of Allow selection change update before beginBatchEdit

Revert of Allow selection change update before beginBatchEdit (patchset #7 id:120001 of https://codereview.chromium.org/2309983002/ )

Reason for revert:
This led to crbug.com/659934 because FROM_IME
message created for endBatchEdit() was consumed by get* method. In this case
state update does not get sent out to InputMethodManager. (really reverting it for M56 as the fix is taking longer)

Original issue's description:
> Allow selection change update before beginBatchEdit
>
> Currently, selection changes immediately before beginBatchEdit() may be
> merged into batch edit selection update which happens at endBatchEdit().
>
> The reason is that it takes round-trip time to get update from previous
> operation and if we increment mNumNestedBatchEdits in beginBatchEdit()
> before the update from renderer process arrives at browser process,
> then the update from operation will be ignored because
> mNumNestedBatchEdits > 0.
>
> This can be prevented if we keep the batch edit information in renderer
> and tag it to each text input state update.
>
> Note that mNumNestedBatchEdits should still be kept in
> ThreadedInputConnection to return the correct value in endBatchEdit().
>
> BUG=644574, 643473, 643477
>
> Committed: https://crrev.com/4662007a92a92b016ef3f05fb4cbbd6904825cc0
> Cr-Commit-Position: refs/heads/master@{#419959}

TBR=aelias@chromium.org,avi@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644574, 643473, 643477
Committed: https://crrev.com/967b73c203ccfb4efdd9f862942b9bbe7efdc644
Cr-Commit-Position: refs/heads/master@{#429837}

[Changwan Ryu, 2016-11-04 06:40:31]

Created Revert of Allow selection change update before beginBatchEdit

[Changwan Ryu, 2016-11-04 06:48:38]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-11-04 06:48:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 06:51:37]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Changwan Ryu, 2016-11-04 07:32:49]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-11-04 07:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 07:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 07:47:45]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Changwan Ryu, 2016-11-04 08:01:24]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-11-04 08:01:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 09:00:20]

Description was changed from

==========
Revert of Allow selection change update before beginBatchEdit (patchset #7
id:120001 of https://codereview.chromium.org/2309983002/ )

Reason for revert:
This led to crbug.com/659934 because FROM_IME
message created for endBatchEdit() was consumed by get* method. In this case
state update does not get sent out to InputMethodManager. (really reverting it
for M56 as the fix is taking longer)

Original issue's description:
> Allow selection change update before beginBatchEdit
> 
> Currently, selection changes immediately before beginBatchEdit() may be
> merged into batch edit selection update which happens at endBatchEdit().
> 
> The reason is that it takes round-trip time to get update from previous
> operation and if we increment mNumNestedBatchEdits in beginBatchEdit()
> before the update from renderer process arrives at browser process,
> then the update from operation will be ignored because
> mNumNestedBatchEdits > 0.
> 
> This can be prevented if we keep the batch edit information in renderer
> and tag it to each text input state update.
> 
> Note that mNumNestedBatchEdits should still be kept in
> ThreadedInputConnection to return the correct value in endBatchEdit().
> 
> BUG=644574, 643473, 643477
> 
> Committed: https://crrev.com/4662007a92a92b016ef3f05fb4cbbd6904825cc0
> Cr-Commit-Position: refs/heads/master@{#419959}

TBR=aelias@chromium.org,avi@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644574, 643473, 643477
==========

to

==========
Revert of Allow selection change update before beginBatchEdit (patchset #7
id:120001 of https://codereview.chromium.org/2309983002/ )

Reason for revert:
This led to crbug.com/659934 because FROM_IME
message created for endBatchEdit() was consumed by get* method. In this case
state update does not get sent out to InputMethodManager. (really reverting it
for M56 as the fix is taking longer)

Original issue's description:
> Allow selection change update before beginBatchEdit
> 
> Currently, selection changes immediately before beginBatchEdit() may be
> merged into batch edit selection update which happens at endBatchEdit().
> 
> The reason is that it takes round-trip time to get update from previous
> operation and if we increment mNumNestedBatchEdits in beginBatchEdit()
> before the update from renderer process arrives at browser process,
> then the update from operation will be ignored because
> mNumNestedBatchEdits > 0.
> 
> This can be prevented if we keep the batch edit information in renderer
> and tag it to each text input state update.
> 
> Note that mNumNestedBatchEdits should still be kept in
> ThreadedInputConnection to return the correct value in endBatchEdit().
> 
> BUG=644574, 643473, 643477
> 
> Committed: https://crrev.com/4662007a92a92b016ef3f05fb4cbbd6904825cc0
> Cr-Commit-Position: refs/heads/master@{#419959}

TBR=aelias@chromium.org,avi@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644574, 643473, 643477
==========

[commit-bot: I haz the power, 2016-11-04 09:00:21]

Committed patchset #3 (id:320001)

[commit-bot: I haz the power, 2016-11-04 09:02:39]

Description was changed from

==========
Revert of Allow selection change update before beginBatchEdit (patchset #7
id:120001 of https://codereview.chromium.org/2309983002/ )

Reason for revert:
This led to crbug.com/659934 because FROM_IME
message created for endBatchEdit() was consumed by get* method. In this case
state update does not get sent out to InputMethodManager. (really reverting it
for M56 as the fix is taking longer)

Original issue's description:
> Allow selection change update before beginBatchEdit
> 
> Currently, selection changes immediately before beginBatchEdit() may be
> merged into batch edit selection update which happens at endBatchEdit().
> 
> The reason is that it takes round-trip time to get update from previous
> operation and if we increment mNumNestedBatchEdits in beginBatchEdit()
> before the update from renderer process arrives at browser process,
> then the update from operation will be ignored because
> mNumNestedBatchEdits > 0.
> 
> This can be prevented if we keep the batch edit information in renderer
> and tag it to each text input state update.
> 
> Note that mNumNestedBatchEdits should still be kept in
> ThreadedInputConnection to return the correct value in endBatchEdit().
> 
> BUG=644574, 643473, 643477
> 
> Committed: https://crrev.com/4662007a92a92b016ef3f05fb4cbbd6904825cc0
> Cr-Commit-Position: refs/heads/master@{#419959}

TBR=aelias@chromium.org,avi@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644574, 643473, 643477
==========

to

==========
Revert of Allow selection change update before beginBatchEdit (patchset #7
id:120001 of https://codereview.chromium.org/2309983002/ )

Reason for revert:
This led to crbug.com/659934 because FROM_IME
message created for endBatchEdit() was consumed by get* method. In this case
state update does not get sent out to InputMethodManager. (really reverting it
for M56 as the fix is taking longer)

Original issue's description:
> Allow selection change update before beginBatchEdit
>
> Currently, selection changes immediately before beginBatchEdit() may be
> merged into batch edit selection update which happens at endBatchEdit().
>
> The reason is that it takes round-trip time to get update from previous
> operation and if we increment mNumNestedBatchEdits in beginBatchEdit()
> before the update from renderer process arrives at browser process,
> then the update from operation will be ignored because
> mNumNestedBatchEdits > 0.
>
> This can be prevented if we keep the batch edit information in renderer
> and tag it to each text input state update.
>
> Note that mNumNestedBatchEdits should still be kept in
> ThreadedInputConnection to return the correct value in endBatchEdit().
>
> BUG=644574, 643473, 643477
>
> Committed: https://crrev.com/4662007a92a92b016ef3f05fb4cbbd6904825cc0
> Cr-Commit-Position: refs/heads/master@{#419959}

TBR=aelias@chromium.org,avi@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644574, 643473, 643477

Committed: https://crrev.com/967b73c203ccfb4efdd9f862942b9bbe7efdc644
Cr-Commit-Position: refs/heads/master@{#429837}
==========

[commit-bot: I haz the power, 2016-11-04 09:02:40]

Patchset 3 (id:??) landed as
https://crrev.com/967b73c203ccfb4efdd9f862942b9bbe7efdc644
Cr-Commit-Position: refs/heads/master@{#429837}