content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java - Issue 2476883003: Revert of Allow selection change update before beginBatchEdit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java

Issue 2476883003: Revert of Allow selection change update before beginBatchEdit (Closed)

Patch Set: fixed build Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java

index dcacae03c8a8d674504d8ae6db051a28bf902a39..aff431612811f0717f46f154c846451544632eb9 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java

@@ -47,11 +47,9 @@ public interface ChromiumBaseInputConnection extends InputConnection {

* @param compositionEnd The character offset of the composition end, or -1 if there is no

* selection.

* @param isNonImeChange True when the update was caused by non-IME (e.g. Javascript).

- * @param inBatchEditMode True when in batch edit mode.

void updateStateOnUiThread(String text, int selectionStart, int selectionEnd,

- int compositionStart, int compositionEnd, boolean singleLine, boolean isNonImeChange,

- boolean inBatchEditMode);

+ int compositionStart, int compositionEnd, boolean singleLine, boolean isNonImeChange);

/**

* Send key event on UI thread.