Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h

Issue 2476783002: Adding a destination platform histogram for UMA. (Closed)
Patch Set: Replacing 'selected' to 'destination', adding a note to the ArcIntentHandlerAction histogram Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h b/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
index 0c7cf3e80e3819f12dc9b424102db64f90af7606..f3fafdcc9144736be81effdf8a26f7935d4ab6cb 100644
--- a/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
+++ b/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
@@ -43,6 +43,12 @@ class ArcNavigationThrottle : public content::NavigationThrottle {
INVALID = SIZE,
};
+ enum class Platform : int {
Yusuke Sato 2016/11/04 00:16:14 please add an enum description (like L33-35).
djacobo_ 2016/11/04 05:53:50 Done.
+ ARC = 0,
+ CHROME = 1,
+ SIZE,
+ };
+
// Restricts the amount of apps displayed to the user without the need of a
// ScrollView.
enum { kMaxAppResults = 3 };
@@ -79,6 +85,9 @@ class ArcNavigationThrottle : public content::NavigationThrottle {
static bool IsSwapElementsNeededForTesting(
const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,
std::pair<size_t, size_t>* out_indices);
+ static Platform GetDestinationPlatform(
Yusuke Sato 2016/11/04 00:16:14 * Since this is a public function, it's better to
djacobo_ 2016/11/04 05:53:50 Moved and added comments, let me know what you thi
+ const std::string& selected_app_package,
+ CloseReason close_reason);
private:
// content::Navigation implementation:

Powered by Google App Engine
This is Rietveld 408576698