Adding a destination platform histogram for UMA.

chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_INTENT_HELPER_ARC_NAVIGATION_THROTTLE_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_INTENT_HELPER_ARC_NAVIGATION_THROTTLE_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 25 matching lines @@
   enum class CloseReason : int {
     ERROR = 0,
     DIALOG_DEACTIVATED = 1,
     ALWAYS_PRESSED = 2,
     JUST_ONCE_PRESSED = 3,
     PREFERRED_ACTIVITY_FOUND = 4,
     SIZE,
     INVALID = SIZE,
   };
 
+  enum class Platform : int {

[Yusuke Sato, 2016/11/04 00:16:14]

please add an enum description (like L33-35).

[djacobo_, 2016/11/04 05:53:50]

Done.

+    ARC = 0,
+    CHROME = 1,
+    SIZE,
+  };
+
   // Restricts the amount of apps displayed to the user without the need of a
   // ScrollView.
   enum { kMaxAppResults = 3 };
 
   struct AppInfo {
     AppInfo(gfx::Image img, std::string package, std::string activity)
         : icon(img), package_name(package), activity_name(activity) {}
     gfx::Image icon;
     std::string package_name;
     std::string activity_name;
@@ skipping 16 matching lines @@
       const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,
       const std::string& selected_app_package);
 
   static bool IsAppAvailableForTesting(
       const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers);
   static size_t FindPreferredAppForTesting(
       const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers);
   static bool IsSwapElementsNeededForTesting(
       const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,
       std::pair<size_t, size_t>* out_indices);
+  static Platform GetDestinationPlatform(

[Yusuke Sato, 2016/11/04 00:16:14]

* Since this is a public function, it's better to add a function comment. It's
unclear what'll be returned when ERROR or DIALOG_DEACTIVATED is passed.
* L81-87 is for ForTesting functions. Please move this to L80.

[djacobo_, 2016/11/04 05:53:50]

Moved and added comments, let me know what you think.

+      const std::string& selected_app_package,
+      CloseReason close_reason);
 
  private:
   // content::Navigation implementation:
   NavigationThrottle::ThrottleCheckResult WillStartRequest() override;
   NavigationThrottle::ThrottleCheckResult WillRedirectRequest() override;
 
   NavigationThrottle::ThrottleCheckResult HandleRequest();
   void OnAppCandidatesReceived(
       mojo::Array<mojom::IntentHandlerInfoPtr> handlers);
   void OnAppIconsReceived(
@@ skipping 19 matching lines @@
 
   // This has to be the last member of the class.
   base::WeakPtrFactory<ArcNavigationThrottle> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcNavigationThrottle);
 };
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_INTENT_HELPER_ARC_NAVIGATION_THROTTLE_H_