Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 24767002: Minor clean-up in base/guid.* (Closed)

Created:
7 years, 2 months ago by vabr (Chromium)
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M base/guid.h View 1 chunk +1 line, -1 line 0 comments Download
M base/guid.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vabr (Chromium)
Hi Nico, As a part of my yesterday's change in base/guid.* I noticed some minor ...
7 years, 2 months ago (2013-09-26 15:05:57 UTC) #1
Nico
lgtm
7 years, 2 months ago (2013-09-26 17:44:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/24767002/1
7 years, 2 months ago (2013-09-27 04:54:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=172889
7 years, 2 months ago (2013-09-27 06:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/24767002/1
7 years, 2 months ago (2013-09-27 06:57:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=172922
7 years, 2 months ago (2013-09-27 08:37:42 UTC) #6
vabr (Chromium)
7 years, 2 months ago (2013-09-27 08:54:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r225681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698