Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: base/guid.cc

Issue 24767002: Minor clean-up in base/guid.* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/guid.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/guid.h" 5 #include "base/guid.h"
6 6
7 #include "base/rand_util.h"
8 #include "base/strings/stringprintf.h"
9
10 namespace base { 7 namespace base {
11 8
12 bool IsValidGUID(const std::string& guid) { 9 bool IsValidGUID(const std::string& guid) {
13 const size_t kGUIDLength = 36U; 10 const size_t kGUIDLength = 36U;
14 if (guid.length() != kGUIDLength) 11 if (guid.length() != kGUIDLength)
15 return false; 12 return false;
16 13
17 std::string hexchars = "0123456789ABCDEF"; 14 const std::string hexchars = "0123456789ABCDEF";
18 for (uint32 i = 0; i < guid.length(); ++i) { 15 for (uint32 i = 0; i < guid.length(); ++i) {
19 char current = guid[i]; 16 char current = guid[i];
20 if (i == 8 || i == 13 || i == 18 || i == 23) { 17 if (i == 8 || i == 13 || i == 18 || i == 23) {
21 if (current != '-') 18 if (current != '-')
22 return false; 19 return false;
23 } else { 20 } else {
24 if (hexchars.find(current) == std::string::npos) 21 if (hexchars.find(current) == std::string::npos)
25 return false; 22 return false;
26 } 23 }
27 } 24 }
28 25
29 return true; 26 return true;
30 } 27 }
31 28
32 } // namespace guid 29 } // namespace base
OLDNEW
« no previous file with comments | « base/guid.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698