Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2476663002:
Check for both use_ozone and is_chromeos for test. (Closed)
DescriptionCheck for both use_ozone and is_chromeos for test.
The display_services_unittest relies on some Chrome OS specific code.
Add appropriate checks so the FYI bot Ozone Linux doesn't fail on it.
BUG=none
Committed: https://crrev.com/9ee25181510dd1db45fe1d089541fc34f7a29274
Cr-Commit-Position: refs/heads/master@{#430179}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 24 (9 generated)
thomasanderson@google.com changed reviewers: + thomasanderson@google.com
Thank you for this kylechar! https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.gn File services/ui/display/BUILD.gn (right): https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.g... services/ui/display/BUILD.gn:43: if (use_ozone && is_chromeos) { Please add a TODO here to make these tests work on Linux ozone. If possible, also create/Xref a bug and make sure to cc me and tonikitoo@igalia.com
https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.gn File services/ui/display/BUILD.gn (right): https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.g... services/ui/display/BUILD.gn:43: if (use_ozone && is_chromeos) { On 2016/11/03 18:17:28, Tom Anderson wrote: > Please add a TODO here to make these tests work on Linux ozone. > If possible, also create/Xref a bug and make sure to cc me and > mailto:tonikitoo@igalia.com Screen management is really a Chrome OS only concept. If we're running on another OS then it's the OS that will do those things and not Chrome.
kylechar@chromium.org changed reviewers: + jochen@chromium.org
Whoops, +jochen for BUILD.gn
lgtm, but please wait for thomasanderson's review as well
Thanks jochen!
lgtm
The CQ bit was checked by kylechar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
rjkroege@chromium.org changed reviewers: + rjkroege@chromium.org
https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.gn File services/ui/display/BUILD.gn (right): https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.g... services/ui/display/BUILD.gn:43: if (use_ozone && is_chromeos) { On 2016/11/03 18:23:55, kylechar wrote: > On 2016/11/03 18:17:28, Tom Anderson wrote: > > Please add a TODO here to make these tests work on Linux ozone. > > If possible, also create/Xref a bug and make sure to cc me and > > mailto:tonikitoo@igalia.com > > Screen management is really a Chrome OS only concept. If we're running on > another OS then it's the OS that will do those things and not Chrome. But... in a future CrOS=0, ozone=1 world, we will still want mus platform screen to do something ratinonal yes? in other words, I think that there's still work for tonikitoo here eventually.
On 2016/11/04 22:52:44, rjkroege wrote: > https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.gn > File services/ui/display/BUILD.gn (right): > > https://codereview.chromium.org/2476663002/diff/1/services/ui/display/BUILD.g... > services/ui/display/BUILD.gn:43: if (use_ozone && is_chromeos) { > On 2016/11/03 18:23:55, kylechar wrote: > > On 2016/11/03 18:17:28, Tom Anderson wrote: > > > Please add a TODO here to make these tests work on Linux ozone. > > > If possible, also create/Xref a bug and make sure to cc me and > > > mailto:tonikitoo@igalia.com > > > > Screen management is really a Chrome OS only concept. If we're running on > > another OS then it's the OS that will do those things and not Chrome. > > But... in a future CrOS=0, ozone=1 world, we will still want mus platform screen > to do something ratinonal yes? in other words, I think that there's still work > for tonikitoo here eventually. Yeah, it definitely needs some rational screen-ish code. It would just be totally different than the CrOS case, working the same as X11 Linux Desktop and Windows works, no?
The CQ bit was checked by kylechar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Check for both use_ozone and is_chromeos for test. The display_services_unittest relies on some Chrome OS specific code. Add appropriate checks so the FYI bot Ozone Linux doesn't fail on it. BUG=none ========== to ========== Check for both use_ozone and is_chromeos for test. The display_services_unittest relies on some Chrome OS specific code. Add appropriate checks so the FYI bot Ozone Linux doesn't fail on it. BUG=none Committed: https://crrev.com/9ee25181510dd1db45fe1d089541fc34f7a29274 Cr-Commit-Position: refs/heads/master@{#430179} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9ee25181510dd1db45fe1d089541fc34f7a29274 Cr-Commit-Position: refs/heads/master@{#430179}
Message was sent while issue was closed.
fwang@igalia.com changed reviewers: + fwang@igalia.com
Message was sent while issue was closed.
Message was sent while issue was closed.
Description was changed from ========== Check for both use_ozone and is_chromeos for test. The display_services_unittest relies on some Chrome OS specific code. Add appropriate checks so the FYI bot Ozone Linux doesn't fail on it. BUG=none Committed: https://crrev.com/9ee25181510dd1db45fe1d089541fc34f7a29274 Cr-Commit-Position: refs/heads/master@{#430179} ========== to ========== Check for both use_ozone and is_chromeos for test. The display_services_unittest relies on some Chrome OS specific code. Add appropriate checks so the FYI bot Ozone Linux doesn't fail on it. BUG=none Committed: https://crrev.com/9ee25181510dd1db45fe1d089541fc34f7a29274 Cr-Commit-Position: refs/heads/master@{#430179} ========== |
