Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 247663006: Add more phony rules to GN build (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add more phony rules to GN build. For a target //foo/bar:bar this adds the additional phony rules: "foo/bar:bar" and "foo/bar" to build.ninja. This is on top of the phony rules "bar" which will exist for all targets with a unique name "bar". This allows one to disambiguate targets with different paths but the same short name. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266680

Patch Set 1 #

Patch Set 2 : no leading // #

Patch Set 3 : fix comment #

Total comments: 1

Patch Set 4 : #

Total comments: 1

Patch Set 5 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -15 lines) Patch
M tools/gn/escape.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/escape_unittest.cc View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M tools/gn/ninja_build_writer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 1 2 3 2 chunks +67 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 7 months ago (2014-04-28 18:33:37 UTC) #1
scottmg
https://codereview.chromium.org/247663006/diff/40001/tools/gn/ninja_build_writer.cc File tools/gn/ninja_build_writer.cc (right): https://codereview.chromium.org/247663006/diff/40001/tools/gn/ninja_build_writer.cc#newcode261 tools/gn/ninja_build_writer.cc:261: ReplaceSubstringsAfterOffset(&escaped, 0, ":", "$:"); shouldn't escape_ninja be doing this?
6 years, 7 months ago (2014-04-28 18:45:21 UTC) #2
brettw
I was thinking not doing the escaping of ':' by default since the colon is ...
6 years, 7 months ago (2014-04-28 19:28:11 UTC) #3
scottmg
lgtm https://codereview.chromium.org/247663006/diff/60001/tools/gn/escape.cc File tools/gn/escape.cc (right): https://codereview.chromium.org/247663006/diff/60001/tools/gn/escape.cc#newcode63 tools/gn/escape.cc:63: dest->push_back(':'); test for this
6 years, 7 months ago (2014-04-28 19:50:53 UTC) #4
brettw
6 years, 7 months ago (2014-04-28 22:40:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r266680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698