tools/gn/escape.cc - Issue 247663006: Add more phony rules to GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/escape.cc

Issue 247663006: Add more phony rules to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/escape.cc

diff --git a/tools/gn/escape.cc b/tools/gn/escape.cc

index e10e24a2b68c48f6a5c0454e33ecd036879320e0..c1acc722a9f036a383aa1052c373e2650d4aae5e 100644

--- a/tools/gn/escape.cc

+++ b/tools/gn/escape.cc

@@ -58,6 +58,9 @@ void EscapeStringToString(const base::StringPiece& str,

} else if (str[i] == '\\' && (options.mode & ESCAPE_JSON)) {

dest->push_back('\\');

+ } else if (str[i] == ':' && (options.mode & ESCAPE_NINJA)) {

+ dest->push_back('$');

+ dest->push_back(':');

} else {

dest->push_back(str[i]);

}

« no previous file with comments | « no previous file | tools/gn/escape_unittest.cc » ('j') | no next file with comments »