Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2476593002: [turbofan] Improve representation selection for HeapObject checking. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve representation selection for HeapObject checking. For lowering CheckHeapObject, always report TaggedPointer representation and let the RepresentationChanger come up with a reasonable conversion from whatever input representation to TaggedPointer. This way we no longer insert the useless ChangeSomethingToTagged and then check the result for HeapObject, i.e. mostly reduces the amount of useless code being generated. Note there are now two operators ChangeFloat64ToTaggedPointer and the old ChangeFloat64ToTagged, because their semantics different wrt. the strength reduction in the SimplifiedOperatorReducer. Also set the output MachineRepresentation::kTaggedPointer properly in SimplifiedLowering whenever we know that we produce a HeapObject. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/6322bf41613fd0df785ae4341e674fa9ee09c9d4 Cr-Commit-Position: refs/heads/master@{#40725}

Patch Set 1 #

Patch Set 2 : REBASE and fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -65 lines) Patch
M src/compiler/effect-control-linearizer.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 6 chunks +30 lines, -16 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/representation-change.h View 5 chunks +12 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 1 5 chunks +49 lines, -6 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 11 chunks +24 lines, -15 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +21 lines, -19 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/machine-type.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-03 10:27:59 UTC) #1
Jarin
lgtm
4 years, 1 month ago (2016-11-03 10:33:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476593002/1
4 years, 1 month ago (2016-11-03 10:36:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15603) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-03 11:01:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476593002/20001
4 years, 1 month ago (2016-11-03 12:25:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 12:52:21 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6322bf41613fd0df785ae4341e674fa9ee09c9d4
Cr-Commit-Position: refs/heads/master@{#40725}

Powered by Google App Engine
This is Rietveld 408576698