Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: src/compiler/verifier.cc

Issue 2476593002: [turbofan] Improve representation selection for HeapObject checking. (Closed)
Patch Set: REBASE and fix. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/simplified-operator-reducer.cc ('k') | src/machine-type.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 970 matching lines...) Expand 10 before | Expand all | Expand 10 after
981 } 981 }
982 case IrOpcode::kChangeFloat64ToTagged: { 982 case IrOpcode::kChangeFloat64ToTagged: {
983 // Number /\ UntaggedFloat64 -> Number /\ Tagged 983 // Number /\ UntaggedFloat64 -> Number /\ Tagged
984 // TODO(neis): Activate once ChangeRepresentation works in typer. 984 // TODO(neis): Activate once ChangeRepresentation works in typer.
985 // Type* from =Type::Intersect(Type::Number(), Type::UntaggedFloat64()); 985 // Type* from =Type::Intersect(Type::Number(), Type::UntaggedFloat64());
986 // Type* to = Type::Intersect(Type::Number(), Type::Tagged()); 986 // Type* to = Type::Intersect(Type::Number(), Type::Tagged());
987 // CheckValueInputIs(node, 0, from)); 987 // CheckValueInputIs(node, 0, from));
988 // CheckTypeIs(node, to)); 988 // CheckTypeIs(node, to));
989 break; 989 break;
990 } 990 }
991 case IrOpcode::kChangeFloat64ToTaggedPointer:
992 break;
991 case IrOpcode::kChangeTaggedToBit: { 993 case IrOpcode::kChangeTaggedToBit: {
992 // Boolean /\ TaggedPtr -> Boolean /\ UntaggedInt1 994 // Boolean /\ TaggedPtr -> Boolean /\ UntaggedInt1
993 // TODO(neis): Activate once ChangeRepresentation works in typer. 995 // TODO(neis): Activate once ChangeRepresentation works in typer.
994 // Type* from = Type::Intersect(Type::Boolean(), Type::TaggedPtr()); 996 // Type* from = Type::Intersect(Type::Boolean(), Type::TaggedPtr());
995 // Type* to = Type::Intersect(Type::Boolean(), Type::UntaggedInt1()); 997 // Type* to = Type::Intersect(Type::Boolean(), Type::UntaggedInt1());
996 // CheckValueInputIs(node, 0, from)); 998 // CheckValueInputIs(node, 0, from));
997 // CheckTypeIs(node, to)); 999 // CheckTypeIs(node, to));
998 break; 1000 break;
999 } 1001 }
1000 case IrOpcode::kChangeBitToTagged: { 1002 case IrOpcode::kChangeBitToTagged: {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 case IrOpcode::kCheckedUint32Mod: 1060 case IrOpcode::kCheckedUint32Mod:
1059 case IrOpcode::kCheckedInt32Mul: 1061 case IrOpcode::kCheckedInt32Mul:
1060 case IrOpcode::kCheckedInt32ToTaggedSigned: 1062 case IrOpcode::kCheckedInt32ToTaggedSigned:
1061 case IrOpcode::kCheckedUint32ToInt32: 1063 case IrOpcode::kCheckedUint32ToInt32:
1062 case IrOpcode::kCheckedUint32ToTaggedSigned: 1064 case IrOpcode::kCheckedUint32ToTaggedSigned:
1063 case IrOpcode::kCheckedFloat64ToInt32: 1065 case IrOpcode::kCheckedFloat64ToInt32:
1064 case IrOpcode::kCheckedTaggedSignedToInt32: 1066 case IrOpcode::kCheckedTaggedSignedToInt32:
1065 case IrOpcode::kCheckedTaggedToInt32: 1067 case IrOpcode::kCheckedTaggedToInt32:
1066 case IrOpcode::kCheckedTaggedToFloat64: 1068 case IrOpcode::kCheckedTaggedToFloat64:
1067 case IrOpcode::kCheckedTaggedToTaggedSigned: 1069 case IrOpcode::kCheckedTaggedToTaggedSigned:
1070 case IrOpcode::kCheckedTaggedToTaggedPointer:
1068 case IrOpcode::kCheckedTruncateTaggedToWord32: 1071 case IrOpcode::kCheckedTruncateTaggedToWord32:
1069 break; 1072 break;
1070 1073
1071 case IrOpcode::kCheckFloat64Hole: 1074 case IrOpcode::kCheckFloat64Hole:
1072 CheckValueInputIs(node, 0, Type::Number()); 1075 CheckValueInputIs(node, 0, Type::Number());
1073 CheckTypeIs(node, Type::Number()); 1076 CheckTypeIs(node, Type::Number());
1074 break; 1077 break;
1075 case IrOpcode::kCheckTaggedHole: 1078 case IrOpcode::kCheckTaggedHole:
1076 CheckValueInputIs(node, 0, Type::Any()); 1079 CheckValueInputIs(node, 0, Type::Any());
1077 CheckTypeIs(node, Type::NonInternal()); 1080 CheckTypeIs(node, Type::NonInternal());
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
1617 replacement->op()->EffectOutputCount() > 0); 1620 replacement->op()->EffectOutputCount() > 0);
1618 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1621 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1619 replacement->opcode() == IrOpcode::kFrameState); 1622 replacement->opcode() == IrOpcode::kFrameState);
1620 } 1623 }
1621 1624
1622 #endif // DEBUG 1625 #endif // DEBUG
1623 1626
1624 } // namespace compiler 1627 } // namespace compiler
1625 } // namespace internal 1628 } // namespace internal
1626 } // namespace v8 1629 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/simplified-operator-reducer.cc ('k') | src/machine-type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698