components/content_settings/core/browser/content_settings_registry.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_registry.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_provider_unittest.cc ('k') | components/content_settings/core/browser/content_settings_rule_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_registry.cc

diff --git a/components/content_settings/core/browser/content_settings_registry.cc b/components/content_settings/core/browser/content_settings_registry.cc

index b147dca2b925e507393ea28c0bb3a7d86cfba8e2..90896c7796b59caa50475552b74d7e41bddc167b 100644

--- a/components/content_settings/core/browser/content_settings_registry.cc

+++ b/components/content_settings/core/browser/content_settings_registry.cc

@@ -327,7 +327,7 @@ void ContentSettingsRegistry::Register(

<< "If INHERIT_IN_INCOGNITO_EXCEPT_ALLOW is set, ASK must be listed as a "

"valid setting.";

std::unique_ptr<base::Value> default_value(

- new base::FundamentalValue(static_cast<int>(initial_default_value)));

+ new base::Value(static_cast<int>(initial_default_value)));

const WebsiteSettingsInfo* website_settings_info =

website_settings_registry_->Register(

type, name, std::move(default_value), sync_status,