components/content_settings/core/browser/content_settings_provider_unittest.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_provider_unittest.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_pref.cc ('k') | components/content_settings/core/browser/content_settings_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_provider_unittest.cc

diff --git a/components/content_settings/core/browser/content_settings_provider_unittest.cc b/components/content_settings/core/browser/content_settings_provider_unittest.cc

index 9b7d217725249e4184321743c4d88387a942250f..3252df9b782d30c7b82f13438d7f9ec87c65cd5e 100644

--- a/components/content_settings/core/browser/content_settings_provider_unittest.cc

+++ b/components/content_settings/core/browser/content_settings_provider_unittest.cc

@@ -23,7 +23,7 @@ TEST(ContentSettingsProviderTest, Mock) {

pattern,

CONTENT_SETTINGS_TYPE_PLUGINS,

"java_plugin",

- new base::FundamentalValue(CONTENT_SETTING_BLOCK));

+ new base::Value(CONTENT_SETTING_BLOCK));

EXPECT_EQ(CONTENT_SETTING_BLOCK,

TestUtils::GetContentSetting(&mock_provider, url, url,

@@ -56,7 +56,7 @@ TEST(ContentSettingsProviderTest, Mock) {

pattern,

CONTENT_SETTINGS_TYPE_PLUGINS,

"java_plugin",

- new base::FundamentalValue(CONTENT_SETTING_ALLOW));

+ new base::Value(CONTENT_SETTING_ALLOW));

EXPECT_TRUE(owned);

EXPECT_EQ(CONTENT_SETTING_ALLOW,

TestUtils::GetContentSetting(&mock_provider, url, url,

@@ -65,7 +65,7 @@ TEST(ContentSettingsProviderTest, Mock) {

mock_provider.set_read_only(true);

std::unique_ptr<base::Value> value(

- new base::FundamentalValue(CONTENT_SETTING_BLOCK));

+ new base::Value(CONTENT_SETTING_BLOCK));

owned = mock_provider.SetWebsiteSetting(

pattern,

@@ -86,7 +86,7 @@ TEST(ContentSettingsProviderTest, Mock) {

pattern,

CONTENT_SETTINGS_TYPE_PLUGINS,

"java_plugin",

- new base::FundamentalValue(CONTENT_SETTING_BLOCK));

+ new base::Value(CONTENT_SETTING_BLOCK));

EXPECT_TRUE(owned);

EXPECT_EQ(CONTENT_SETTING_BLOCK,

TestUtils::GetContentSetting(&mock_provider, url, url,