Enable syntax-only support for generic functions by default.

Enable syntax-only support for generic functions by default.

This CL removes the 'DartOptions=--generic-method-syntax' directives in
test cases concerned with generic functions and enables that feature by
default. The option '--generic-method-syntax' is still allowed, but the
feature is always enabled so the option makes no difference.

R=johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/70fa0defe9b416669b6e01acf9f31d49aac3426f

[eernst, 2016-11-09 13:52:52]

eernst@google.com changed reviewers:
+ johnniwinther@google.com

[eernst, 2016-11-09 13:52:53]

Enabling --generic-method-syntax by default.

Note that this CL will only be landed when we have decided on exactly how to
enable the feature by default. It is a breaking change because `foo(a < b, c >
(d))` used to be an invocation passing two booleans to `foo`, but now it is
passing one value which is the result of calling the generic function `a` with
type arguments `b, c` and value argument `d`; but it is not expected to break
many programs in practice, maybe none at all.

[Johnni Winther, 2016-11-09 14:02:45]

lgtm

[Siggi Cherem (dart-lang), 2016-11-10 20:54:50]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-11-10 20:54:50]

lgtm, thanks Erik!

https://codereview.chromium.org/2476423005/diff/1/pkg/compiler/lib/src/option...
File pkg/compiler/lib/src/options.dart (right):

https://codereview.chromium.org/2476423005/diff/1/pkg/compiler/lib/src/option...
pkg/compiler/lib/src/options.dart:292: true, // No check for
`Flags.genericMethodSyntax`: always enabled.
suggestion: consider deleting this property from here and ParserOptions
altogether. I'd be OK doing that on a separate CL, but I'm also happy to do it
at once. Note: we will still accept the flag on the command line with the rest
of your changes as you have them (since it's still listed in
command_options.dart). This will just simplify the API internally within the
compiler.

[eernst, 2016-11-18 08:56:26]

Description was changed from

==========
Enable syntax-only support for generic functions by default.

This CL removes the 'DartOptions=--generic-method-syntax' directives in
test cases concerned with generic functions and enables that feature by
default. The option '--generic-method-syntax' is still allowed, but the
feature is always enabled so the option makes no difference.
==========

to

==========
Enable syntax-only support for generic functions by default.

This CL removes the 'DartOptions=--generic-method-syntax' directives in
test cases concerned with generic functions and enables that feature by
default. The option '--generic-method-syntax' is still allowed, but the
feature is always enabled so the option makes no difference.

R=johnniwinther@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/70fa0defe9b416669b6e01acf9f31d49aac3426f
==========

[eernst, 2016-11-18 08:56:28]

Committed patchset #1 (id:1) manually as
70fa0defe9b416669b6e01acf9f31d49aac3426f (presubmit successful).

[eernst, 2016-11-22 09:33:16]

As mentioned in email, 'deleting this property from here
and ParserOptions' will be handled in a separate CL.