Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pkg/compiler/lib/src/commandline_options.dart

Issue 2476423005: Enable syntax-only support for generic functions by default. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/diagnostics/messages.dart » ('j') | pkg/compiler/lib/src/options.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/commandline_options.dart
diff --git a/pkg/compiler/lib/src/commandline_options.dart b/pkg/compiler/lib/src/commandline_options.dart
index 94a751c42605e4143759bb0279f7401d04f03878..8d7b73589a3d6c02c21ff832e0bcf7453b8d08b5 100644
--- a/pkg/compiler/lib/src/commandline_options.dart
+++ b/pkg/compiler/lib/src/commandline_options.dart
@@ -51,11 +51,17 @@ class Flags {
static const String conditionalDirectives = '--conditional-directives';
- // Experimental flags.
-
- // Considerations about this feature (esp. locations where generalizations
- // or changes are required for full support of generic methods) are marked
- // with 'GENERIC_METHODS'. The approach taken is to parse generic methods,
+ // The syntax-only level of support for generic methods is included in the
+ // 1.50 milestone for Dart. It is not experimental, but also not permanent:
+ // a full implementation is expected in the future. Hence, the
+ // 'GENERIC_METHODS' comments which were added when this feature was
+ // experimental have been preserved, such that it will be easy to find the
+ // relevant locations to update when generic methods are implemented fully.
+ //
+ // The option is still accepted, but it has no effect: The feature is enabled
+ // by default and it cannot be disabled.
+ //
+ // The approach taken in the implementation is to parse generic methods,
// introduce AST nodes for them, generate corresponding types (such that
// front end treatment is consistent with the code that programmers wrote),
// but considering all method type variables to have bound `dynamic` no
@@ -63,7 +69,12 @@ class Flags {
// is unchecked), and then replacing method type variables by a `DynamicType`
// (such that the backend does not need to take method type arguments into
// account).
+ //
+ // The feature has an informal specification which is available at
+ // https://gist.github.com/eernstg/4353d7b4f669745bed3a5423e04a453c.
static const String genericMethodSyntax = '--generic-method-syntax';
+
+ // Experimental flags.
static const String resolveOnly = '--resolve-only';
static const String initializingFormalAccess = '--initializing-formal-access';
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/diagnostics/messages.dart » ('j') | pkg/compiler/lib/src/options.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698