[sensors][win] Implementation of motion sensors for Win platform

[sensors][win] Implementation of motion sensors for Win platform

This CL adds support for Accelerometer, Gyroscope and Magnetometer
sensors for Windows platform. Unit tests are modified to test new
funtionality and data conversion between units provided by Windows
platform and SI units.

BUG=661478
Committed: https://crrev.com/cfa527a782a6dfc6b8f76df8ae309003ece94c02
Cr-Commit-Position: refs/heads/master@{#432444}

[shalamov, 2016-11-08 14:54:30]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:54:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 16:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 16:28:18]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[shalamov, 2016-11-08 17:59:40]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 18:00:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 19:24:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 19:24:14]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[shalamov, 2016-11-09 09:00:05]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 09:00:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shalamov, 2016-11-09 09:04:17]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-09 09:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 09:49:35]

Dry run: This issue passed the CQ dry run.

[shalamov, 2016-11-09 10:37:10]

alexander.shalamov@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com, reillyg@chromium.org, timvolodine@chromium.org

[shalamov, 2016-11-09 10:37:10]

Please take a look.

[Mikhail, 2016-11-09 10:42:58]

lgtm

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_and_provider_unittest_win.cc (right):

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_and_provider_unittest_win.cc:339:
variant->dblVal = (*it).second;
nit: it->second

[Reilly Grant (use Gerrit), 2016-11-09 17:11:28]

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_reader_win.cc (right):

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_reader_win.cc:83: params->reporting_mode =
mojom::ReportingMode::CONTINUOUS;
Is this really continuous? Last time I played with this API it only reported
values when the device moved.

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_reader_win.cc:162: // Reverse sings for
values and convert from Milligaus to
s/sings/signs/

Though, I'd prefer a repeat of the full coordinate system comment from above.

[shalamov, 2016-11-10 13:20:04]

Patchset #3 (id:60001) has been deleted

[shalamov, 2016-11-10 13:38:10]

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_and_provider_unittest_win.cc (right):

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_and_provider_unittest_win.cc:339:
variant->dblVal = (*it).second;
On 2016/11/09 10:42:58, Mikhail wrote:
> nit: it->second

Done.

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_reader_win.cc (right):

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_reader_win.cc:83: params->reporting_mode =
mojom::ReportingMode::CONTINUOUS;
On 2016/11/09 17:11:28, Reilly Grant wrote:
> Is this really continuous? Last time I played with this API it only reported
> values when the device moved.

You are right, I modified code accordingly.

I was hoping that knowing sensor accuracy + modifying sensitivity parameters can
mimic Android (IIO) CONTINUOUS sensor behavior, but after few tests on old / new
Windows devices, result is that device will report nothing until moved.

https://codereview.chromium.org/2476363003/diff/40001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_reader_win.cc:162: // Reverse sings for
values and convert from Milligaus to
On 2016/11/09 17:11:28, Reilly Grant wrote:
> s/sings/signs/
> 
> Though, I'd prefer a repeat of the full coordinate system comment from above.

I copied coordinate system note for all sensors that require sign switch for
axes.

[shalamov, 2016-11-14 13:19:59]

On 2016/11/09 17:11:28, Reilly Grant wrote:
> Though, I'd prefer a repeat of the full coordinate system comment from above.

Reilly, do you have more comments?
Maxim made file with constants I will wait for his CL to land and remove
duplicated consts from this CL.

[Reilly Grant (use Gerrit), 2016-11-14 20:40:16]

On 2016/11/14 at 13:19:59, alexander.shalamov wrote:
> On 2016/11/09 17:11:28, Reilly Grant wrote:
> > Though, I'd prefer a repeat of the full coordinate system comment from
above.
> 
> Reilly, do you have more comments?
> Maxim made file with constants I will wait for his CL to land and remove
duplicated consts from this CL.

Thank you. lgtm.

[shalamov, 2016-11-15 11:31:37]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 11:31:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 12:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 12:46:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[shalamov, 2016-11-16 07:07:21]

The CQ bit was checked by alexander.shalamov@intel.com

[shalamov, 2016-11-16 07:07:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikhail.pozdnyakov@intel.com, reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2476363003/#ps100001
(title: "Rebased to master")

[commit-bot: I haz the power, 2016-11-16 07:07:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 09:38:58]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-11-16 09:41:09]

Description was changed from

==========
[sensors][win] Implementation of motion sensors for Win platform

This CL adds support for Accelerometer, Gyroscope and Magnetometer
sensors for Windows platform. Unit tests are modified to test new
funtionality and data conversion between units provided by Windows
platform and SI units.

BUG=661478
==========

to

==========
[sensors][win] Implementation of motion sensors for Win platform

This CL adds support for Accelerometer, Gyroscope and Magnetometer
sensors for Windows platform. Unit tests are modified to test new
funtionality and data conversion between units provided by Windows
platform and SI units.

BUG=661478

Committed: https://crrev.com/cfa527a782a6dfc6b8f76df8ae309003ece94c02
Cr-Commit-Position: refs/heads/master@{#432444}
==========

[commit-bot: I haz the power, 2016-11-16 09:41:10]

Patchset 4 (id:??) landed as
https://crrev.com/cfa527a782a6dfc6b8f76df8ae309003ece94c02
Cr-Commit-Position: refs/heads/master@{#432444}