Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2199)

Unified Diff: device/generic_sensor/platform_sensor_win.cc

Issue 2476363003: [sensors][win] Implementation of motion sensors for Win platform (Closed)
Patch Set: Rebased to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/generic_sensor/platform_sensor_reader_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/generic_sensor/platform_sensor_win.cc
diff --git a/device/generic_sensor/platform_sensor_win.cc b/device/generic_sensor/platform_sensor_win.cc
index a839f7e7725ea47bf32e947ebfedad50eb5fab35..a3e82cbddb8a14d85320cdf3a147c31e8db6692c 100644
--- a/device/generic_sensor/platform_sensor_win.cc
+++ b/device/generic_sensor/platform_sensor_win.cc
@@ -29,7 +29,9 @@ PlatformSensorConfiguration PlatformSensorWin::GetDefaultConfiguration() {
}
mojom::ReportingMode PlatformSensorWin::GetReportingMode() {
- return sensor_reader_->GetReportingMode();
+ // All Windows sensors, even with high accuracy / sensitivity will not report
+ // reading updates continuously. Therefore, return ON_CHANGE by default.
+ return mojom::ReportingMode::ON_CHANGE;
}
double PlatformSensorWin::GetMaximumSupportedFrequency() {
@@ -41,8 +43,9 @@ double PlatformSensorWin::GetMaximumSupportedFrequency() {
}
void PlatformSensorWin::OnReadingUpdated(const SensorReading& reading) {
- UpdateSensorReading(reading,
- GetReportingMode() == mojom::ReportingMode::ON_CHANGE);
+ // Default reporting mode is ON_CHANGE, thus, set notify_clients parameter
+ // to true.
+ UpdateSensorReading(reading, true);
}
void PlatformSensorWin::OnSensorError() {
« no previous file with comments | « device/generic_sensor/platform_sensor_reader_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698