Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2476353007: MD Settings: ignore 0% updates on help/about page (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: ignore 0% updates on help/about page R=dpapad@chromium.org BUG=663507 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0b695038aa4397ef763fc51b80fbdb0202026b6e Cr-Commit-Position: refs/heads/master@{#431080}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M chrome/app/settings_chromium_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 1 chunk +9 lines, -1 line 1 comment Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/about_page_tests.js View 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Beam
https://codereview.chromium.org/2476353007/diff/1/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2476353007/diff/1/chrome/browser/resources/settings/about_page/about_page.js#newcode170 chrome/browser/resources/settings/about_page/about_page.js:170: progressPercent); i don't really care much about making a ...
4 years, 1 month ago (2016-11-09 21:21:13 UTC) #4
dpapad
LGTM.
4 years, 1 month ago (2016-11-09 21:35:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476353007/1
4 years, 1 month ago (2016-11-09 23:12:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 23:39:58 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 23:51:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b695038aa4397ef763fc51b80fbdb0202026b6e
Cr-Commit-Position: refs/heads/master@{#431080}

Powered by Google App Engine
This is Rietveld 408576698