Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2476353007: MD Settings: ignore 0% updates on help/about page (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index dc61dbb1f5cc056455c123503d309d6fad3174e5..529455f4f98e352a1b5ed4aece4f245ab772f304 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -170,7 +170,15 @@ Polymer({
progressPercent);
Dan Beam 2016/11/09 21:21:13 i don't really care much about making a non-percen
}
</if>
- return this.i18n('aboutUpgradeUpdating', progressPercent);
+ if (this.currentUpdateStatusEvent_.progress > 0) {
+ // NOTE(dbeam): some platforms (i.e. Mac) always send 0% while
+ // updating (they don't support incremental upgrade progress). Though
+ // it's certainly quite possible to validly end up here with 0% on
+ // platforms that support incremental progress, nobody really likes
+ // seeing that they're 0% done with something.
+ return this.i18n('aboutUpgradeUpdatingPercent', progressPercent);
+ }
+ return this.i18n('aboutUpgradeUpdating');
default:
var message = this.currentUpdateStatusEvent_.message;
return message ?
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698