RAPPOR metric for usage of RTCPeerConnection without connecting.

RAPPOR metric for usage of RTCPeerConnection without connecting.

This is to detect certain kinds of usage where we suspect that
people are using PeerConnection for fingerprinting or VPN-detection.

BUG=685950
Review-Url: https://codereview.chromium.org/2476323002
Cr-Commit-Position: refs/heads/master@{#446936}
Committed: https://chromium.googlesource.com/chromium/src/+/f766db29b990d87a3933a27079c2cf14f09aa4b7

[hta - Chromium, 2017-01-27 07:50:56]

Description was changed from

==========
RAPPOR metric for usage of RTCPeerConnection without connecting.

This is to detect certain kinds of usage where we suspect that
people are using PeerConnection for fingerprinting or VPN-detection.

This is a basis for discussion.

BUG=0
==========

to

==========
RAPPOR metric for usage of RTCPeerConnection without connecting.

This is to detect certain kinds of usage where we suspect that
people are using PeerConnection for fingerprinting or VPN-detection.

BUG=685950
==========

[hta - Chromium, 2017-01-27 07:50:56]

hta@chromium.org changed reviewers:
+ holte@google.com, tommi@chromium.org

[hta - Chromium, 2017-01-27 07:51:12]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 07:51:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hta - Chromium, 2017-01-27 07:51:43]

This should be ready for review.
I did not figure out how to unit-test that the metric is recorded.

[hta - Chromium, 2017-01-27 09:08:43]

hta@chromium.org changed reviewers:
+ japhet@chromium.org

[hta - Chromium, 2017-01-27 09:09:07]

On 2017/01/27 07:51:43, hta - Chromium wrote:
> This should be ready for review.
> I did not figure out how to unit-test that the metric is recorded.

Adding japhet@ for core/frame

[commit-bot: I haz the power, 2017-01-27 09:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 09:26:17]

Dry run: This issue passed the CQ dry run.

[Steven Holte, 2017-01-27 20:36:31]

holte@chromium.org changed reviewers:
+ holte@chromium.org

[Steven Holte, 2017-01-27 20:36:31]

lgtm

[Nate Chapin, 2017-01-27 20:38:59]

LGTM w/nit

https://codereview.chromium.org/2476323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/HostsUsingFeatures.h (right):

https://codereview.chromium.org/2476323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/HostsUsingFeatures.h:45:
RTCPeerConnectionUsed,  // Note: Special treatment.
This comment doesn't really add anything. Please either describe the "Special
treatment" or remove the comment.

[tommi (sloooow) - chröme, 2017-01-27 23:27:25]

lgtm. with a clearer comment (or no comment)

[hta - Chromium, 2017-01-29 03:12:38]

Thanks!

https://codereview.chromium.org/2476323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/HostsUsingFeatures.h (right):

https://codereview.chromium.org/2476323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/HostsUsingFeatures.h:45:
RTCPeerConnectionUsed,  // Note: Special treatment.
On 2017/01/27 20:38:59, Nate Chapin wrote:
> This comment doesn't really add anything. Please either describe the "Special
> treatment" or remove the comment.

Changed to "Used to compute the "unconnected PCs" feature".
All the others are directly reported, I think, while this one is part of a
computation.

[hta - Chromium, 2017-01-29 03:12:43]

The CQ bit was checked by hta@chromium.org

[hta - Chromium, 2017-01-29 03:12:43]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
tommi@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2476323002/#ps40001
(title: "Updated comment")

[commit-bot: I haz the power, 2017-01-29 03:12:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 04:50:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485659563406250,
"parent_rev": "7288124e6c7c52f9c55d684d657f1fd2df0ea1e3", "commit_rev":
"f766db29b990d87a3933a27079c2cf14f09aa4b7"}

[commit-bot: I haz the power, 2017-01-29 04:51:31]

Description was changed from

==========
RAPPOR metric for usage of RTCPeerConnection without connecting.

This is to detect certain kinds of usage where we suspect that
people are using PeerConnection for fingerprinting or VPN-detection.

BUG=685950
==========

to

==========
RAPPOR metric for usage of RTCPeerConnection without connecting.

This is to detect certain kinds of usage where we suspect that
people are using PeerConnection for fingerprinting or VPN-detection.

BUG=685950

Review-Url: https://codereview.chromium.org/2476323002
Cr-Commit-Position: refs/heads/master@{#446936}
Committed:
https://chromium.googlesource.com/chromium/src/+/f766db29b990d87a3933a27079c2...
==========

[commit-bot: I haz the power, 2017-01-29 04:51:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f766db29b990d87a3933a27079c2...