Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: content/browser/loader/detachable_resource_handler.h

Issue 2476163003: Refactor ResourceHandler API. (Closed)
Patch Set: Minor cleanups, one real fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/detachable_resource_handler.h
diff --git a/content/browser/loader/detachable_resource_handler.h b/content/browser/loader/detachable_resource_handler.h
index c9199499da1efbd6f796bc726984e34697998324..2108904ed5b8ae3b529dab360a29674936436921 100644
--- a/content/browser/loader/detachable_resource_handler.h
+++ b/content/browser/loader/detachable_resource_handler.h
@@ -49,15 +49,16 @@ class DetachableResourceHandler : public ResourceHandler,
// ResourceHandler implementation:
void SetController(ResourceController* controller) override;
- bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
+ void OnRequestRedirected(const net::RedirectInfo& redirect_info,
ResourceResponse* response,
- bool* defer) override;
- bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
- bool OnWillStart(const GURL& url, bool* defer) override;
+ bool* defer_or_cancel) override;
+ void OnResponseStarted(ResourceResponse* response,
+ bool* defer_or_cancel) override;
+ void OnWillStart(const GURL& url, bool* defer_or_cancel) override;
bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
int* buf_size,
int min_size) override;
- bool OnReadCompleted(int bytes_read, bool* defer) override;
+ void OnReadCompleted(int bytes_read, bool* defer_or_cancel) override;
void OnResponseCompleted(const net::URLRequestStatus& status,
bool* defer) override;
void OnDataDownloaded(int bytes_downloaded) override;
@@ -77,6 +78,7 @@ class DetachableResourceHandler : public ResourceHandler,
bool is_deferred_;
bool is_finished_;
+ bool is_canceled_;
DISALLOW_COPY_AND_ASSIGN(DetachableResourceHandler);
};
« no previous file with comments | « content/browser/loader/async_resource_handler.cc ('k') | content/browser/loader/detachable_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698