Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: content/browser/loader/detachable_resource_handler.h

Issue 2476163003: Refactor ResourceHandler API. (Closed)
Patch Set: Minor cleanups, one real fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_LOADER_DETACHABLE_RESOURCE_HANDLER_H_ 5 #ifndef CONTENT_BROWSER_LOADER_DETACHABLE_RESOURCE_HANDLER_H_
6 #define CONTENT_BROWSER_LOADER_DETACHABLE_RESOURCE_HANDLER_H_ 6 #define CONTENT_BROWSER_LOADER_DETACHABLE_RESOURCE_HANDLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 bool is_detached() const { return next_handler_ == NULL; } 43 bool is_detached() const { return next_handler_ == NULL; }
44 void Detach(); 44 void Detach();
45 45
46 void set_cancel_delay(base::TimeDelta cancel_delay) { 46 void set_cancel_delay(base::TimeDelta cancel_delay) {
47 cancel_delay_ = cancel_delay; 47 cancel_delay_ = cancel_delay;
48 } 48 }
49 49
50 // ResourceHandler implementation: 50 // ResourceHandler implementation:
51 void SetController(ResourceController* controller) override; 51 void SetController(ResourceController* controller) override;
52 bool OnRequestRedirected(const net::RedirectInfo& redirect_info, 52 void OnRequestRedirected(const net::RedirectInfo& redirect_info,
53 ResourceResponse* response, 53 ResourceResponse* response,
54 bool* defer) override; 54 bool* defer_or_cancel) override;
55 bool OnResponseStarted(ResourceResponse* response, bool* defer) override; 55 void OnResponseStarted(ResourceResponse* response,
56 bool OnWillStart(const GURL& url, bool* defer) override; 56 bool* defer_or_cancel) override;
57 void OnWillStart(const GURL& url, bool* defer_or_cancel) override;
57 bool OnWillRead(scoped_refptr<net::IOBuffer>* buf, 58 bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
58 int* buf_size, 59 int* buf_size,
59 int min_size) override; 60 int min_size) override;
60 bool OnReadCompleted(int bytes_read, bool* defer) override; 61 void OnReadCompleted(int bytes_read, bool* defer_or_cancel) override;
61 void OnResponseCompleted(const net::URLRequestStatus& status, 62 void OnResponseCompleted(const net::URLRequestStatus& status,
62 bool* defer) override; 63 bool* defer) override;
63 void OnDataDownloaded(int bytes_downloaded) override; 64 void OnDataDownloaded(int bytes_downloaded) override;
64 65
65 // ResourceController implementation: 66 // ResourceController implementation:
66 void Resume() override; 67 void Resume() override;
67 void Cancel() override; 68 void Cancel() override;
68 void CancelAndIgnore() override; 69 void CancelAndIgnore() override;
69 void CancelWithError(int error_code) override; 70 void CancelWithError(int error_code) override;
70 71
71 private: 72 private:
72 std::unique_ptr<ResourceHandler> next_handler_; 73 std::unique_ptr<ResourceHandler> next_handler_;
73 scoped_refptr<net::IOBuffer> read_buffer_; 74 scoped_refptr<net::IOBuffer> read_buffer_;
74 75
75 std::unique_ptr<base::OneShotTimer> detached_timer_; 76 std::unique_ptr<base::OneShotTimer> detached_timer_;
76 base::TimeDelta cancel_delay_; 77 base::TimeDelta cancel_delay_;
77 78
78 bool is_deferred_; 79 bool is_deferred_;
79 bool is_finished_; 80 bool is_finished_;
81 bool is_canceled_;
80 82
81 DISALLOW_COPY_AND_ASSIGN(DetachableResourceHandler); 83 DISALLOW_COPY_AND_ASSIGN(DetachableResourceHandler);
82 }; 84 };
83 85
84 } // namespace content 86 } // namespace content
85 87
86 #endif // CONTENT_BROWSER_LOADER_DETACHABLE_RESOURCE_HANDLER_H_ 88 #endif // CONTENT_BROWSER_LOADER_DETACHABLE_RESOURCE_HANDLER_H_
OLDNEW
« no previous file with comments | « content/browser/loader/async_resource_handler.cc ('k') | content/browser/loader/detachable_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698