Change call-sites now that SkCanvas is not ref-counted

cc/test/fake_content_layer_client.cc

Index: cc/test/fake_content_layer_client.cc
diff --git a/cc/test/fake_content_layer_client.cc b/cc/test/fake_content_layer_client.cc
index 11c8b3e6cae7c7ba13e8945c45e77870f3fc8105..e2bda7eabfd5b9b7be59f2b9072d90dd2d60b8fb 100644
--- a/cc/test/fake_content_layer_client.cc
+++ b/cc/test/fake_content_layer_client.cc
@@ -58,13 +58,13 @@ FakeContentLayerClient::PaintContentsToDisplayList(
       DisplayItemList::Create(settings);
   display_list->SetRetainVisualRectsForTesting(true);
   SkPictureRecorder recorder;
-  sk_sp<SkCanvas> canvas;
+  SkCanvas* canvas;
 
   for (RectPaintVector::const_iterator it = draw_rects_.begin();
        it != draw_rects_.end(); ++it) {
     const gfx::RectF& draw_rect = it->first;
     const SkPaint& paint = it->second;
-    canvas = sk_ref_sp(recorder.beginRecording(gfx::RectFToSkRect(draw_rect)));
+    canvas = recorder.beginRecording(gfx::RectFToSkRect(draw_rect));

[danakj, 2016/11/14 19:35:15]

move the defn here so we don't have an uninit ptr and then a dangling ptr when
leaving scope

[reed1, 2016/11/14 20:50:08]

Done.

     canvas->drawRect(gfx::RectFToSkRect(draw_rect), paint);
     display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
         ToEnclosingRect(draw_rect), recorder.finishRecordingAsPicture());
@@ -76,8 +76,7 @@ FakeContentLayerClient::PaintContentsToDisplayList(
       display_list->CreateAndAppendPairedBeginItem<TransformDisplayItem>(
           it->transform);
     }
-    canvas = sk_ref_sp(
-        recorder.beginRecording(it->image->width(), it->image->height()));
+    canvas = recorder.beginRecording(it->image->width(), it->image->height());

[danakj, 2016/11/14 19:35:15]

also define another var here

[reed1, 2016/11/14 20:50:08]

Done.

     canvas->drawImage(it->image.get(), it->point.x(), it->point.y(),
                       &it->paint);
     display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
@@ -93,7 +92,7 @@ FakeContentLayerClient::PaintContentsToDisplayList(
     while (!draw_rect.IsEmpty()) {
       SkPaint paint;
       paint.setColor(red ? SK_ColorRED : SK_ColorBLUE);
-      canvas = sk_ref_sp(recorder.beginRecording(gfx::RectToSkRect(draw_rect)));
+      canvas = recorder.beginRecording(gfx::RectToSkRect(draw_rect));

[danakj, 2016/11/14 19:35:15]

and here

[reed1, 2016/11/14 20:50:08]

Done.

       canvas->drawIRect(gfx::RectToSkIRect(draw_rect), paint);
       display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
           draw_rect, recorder.finishRecordingAsPicture());