Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: components/display_compositor/compositor_overlay_candidate_validator_ozone.cc

Issue 2476103002: Disable fullscren fb optimization with sw mirroring. (Closed)
Patch Set: We now call CheckOverlaySupport. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
diff --git a/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc b/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
index ada664cb0bfc549e8a05c10739bd788f9318b8f9..3c0cfb12c230fd6fedb1cd2bf797edbac8968a16 100644
--- a/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
+++ b/components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
@@ -42,7 +42,8 @@ CompositorOverlayCandidateValidatorOzone::
void CompositorOverlayCandidateValidatorOzone::GetStrategies(
cc::OverlayProcessor::StrategyList* strategies) {
if (single_fullscreen_) {
- strategies->push_back(base::MakeUnique<cc::OverlayStrategyFullscreen>());
+ strategies->push_back(
+ base::MakeUnique<cc::OverlayStrategyFullscreen>(this));
} else {
strategies->push_back(
base::MakeUnique<cc::OverlayStrategySingleOnTop>(this));
@@ -58,8 +59,16 @@ void CompositorOverlayCandidateValidatorOzone::CheckOverlaySupport(
cc::OverlayCandidateList* surfaces) {
// SW mirroring copies out of the framebuffer, so we can't remove any
// quads for overlaying, otherwise the output is incorrect.
- if (software_mirror_active_)
+ if (software_mirror_active_) {
+ for (size_t i = 0; i < surfaces->size(); i++) {
+ surfaces->at(i).overlay_handled = false;
+ }
return;
+ }
+
+ if (single_fullscreen_) {
+ return; // No need for validation for single fullscreen.
+ }
DCHECK_GE(2U, surfaces->size());
ui::OverlayCandidatesOzone::OverlaySurfaceCandidateList ozone_surface_list;
« no previous file with comments | « cc/output/overlay_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698