[recipe_modules/test_result] Support uploading full json results format for upload_test_results.py

[recipe_modules/test_result] Support uploading full json results format for upload_test_results.py

BUG=649762
Committed: https://chromium.googlesource.com/chromium/tools/build/+/bb373a58224d53e35a9c6231ce7cbf999664a2ab

[nednguyen, 2016-11-04 17:40:20]

Description was changed from

==========
Support uploading full json test results format for upload_test_results.py
script

BUG=649762
==========

to

==========
[recipe_modules/test_result] Support uploading full json results format for
upload_test_results.py

BUG=649762
==========

[nednguyen, 2016-11-04 17:40:20]

nednguyen@google.com changed reviewers:
+ estaab@chromium.org, phajdan.jr@chromium.org

[estaab, 2016-11-07 00:13:21]

lgtm

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
(right):

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_results/resources/upload_test_results.py:139:
if content.get('version') == 3:
maybe >=3? This seems brittle since later versions will likely retain backward
compatibility.

[Paweł Hajdan Jr., 2016-11-07 08:30:27]

LGTM w/nit

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
File
scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
(right):

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py:147:
try:
nit: Since "finally" removes the directory, should "try" start immediately after
mkdtemp?

Otherwise if say json writing above fails, we'd leak the temp dir.

[nednguyen, 2016-11-07 14:26:24]

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
(right):

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_results/resources/upload_test_results.py:139:
if content.get('version') == 3:
On 2016/11/07 00:13:21, estaab wrote:
> maybe >=3? This seems brittle since later versions will likely retain backward
> compatibility.

Done.

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
File
scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
(right):

https://codereview.chromium.org/2475973002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py:147:
try:
On 2016/11/07 08:30:27, Paweł Hajdan Jr. wrote:
> nit: Since "finally" removes the directory, should "try" start immediately
after
> mkdtemp?
> 
> Otherwise if say json writing above fails, we'd leak the temp dir.

Done.

[nednguyen, 2016-11-07 14:26:27]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-11-07 14:26:28]

The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2475973002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-11-07 14:26:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 14:36:26]

Description was changed from

==========
[recipe_modules/test_result] Support uploading full json results format for
upload_test_results.py

BUG=649762
==========

to

==========
[recipe_modules/test_result] Support uploading full json results format for
upload_test_results.py

BUG=649762

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/bb373a58224d53e35a9c...
==========

[commit-bot: I haz the power, 2016-11-07 14:36:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/bb373a58224d53e35a9c...