[recipe_modules/test_result] Support uploading full json results format for upload_test_results.py

scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py

 #!/usr/bin/env python
 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for upload_test_results.py."""
 
 import json
 import os
 import shutil
@@ skipping 61 matching lines @@
         }],
     }
     results = upload_test_results.get_results_map_from_json(
         json.dumps(contents))
     self.assertEquals(results['Disabled.Test'][0].DISABLED,
                       results['Disabled.Test'][0].modifier)
     self.assertEquals(results['Disabled.Test'][0].DISABLED,
                       results['Skipped.Test'][0].modifier)
 
   @mock.patch('test_results_uploader.upload_test_results')
-  def test_main(self, uploader_mock):
+  def test_main_gtest_json(self, uploader_mock):
     contents = {
         'per_iteration_data': [{
             'Fake.Test': [
                 {'status': 'XXX', 'elapsed_time_ms': 1000},
             ],
         }],
     }
     result_directory = tempfile.mkdtemp()
     input_json_file_path = os.path.join(result_directory, 'results.json')
     with open(input_json_file_path, 'w') as f:
@@ skipping 14 matching lines @@
          os.path.join(result_directory,
                       upload_test_results.TIMES_MS_FILENAME))]
       uploader_mock.assert_called_with(
           'foo',
           [('builder', 'DUMMY_BUILDER_NAME'),
            ('testtype', 'foo'),
            ('master', 'sauron')], files, 120)
     finally:
       shutil.rmtree(result_directory)
 
+  @mock.patch('test_results_uploader.upload_test_results')
+  def test_main_full_results_json(self, uploader_mock):
+    contents = {
+        'tests': {
+            'mojom_tests': {
+              'parse': {
+                'ast_unittest': {
+                  'ASTTest': {
+                    'testNodeBase': {
+                      'expected': 'PASS',
+                      'actual': 'PASS'
+                    }
+                  }
+                }
+              }
+            }
+          },
+          'interrupted': False,
+          'path_delimiter': '.',
+          'version': 3,
+          'seconds_since_epoch': 1406662283.764424,
+          'num_failures_by_type': {
+            'FAIL': 0,
+            'PASS': 1
+          }
+    }
+    result_directory = tempfile.mkdtemp()
+    input_json_file_path = os.path.join(result_directory, 'results.json')
+    with open(input_json_file_path, 'w') as f:
+      json.dump(contents, f)
+    try:

[Paweł Hajdan Jr., 2016/11/07 08:30:27]

nit: Since "finally" removes the directory, should "try" start immediately after
mkdtemp?

Otherwise if say json writing above fails, we'd leak the temp dir.

[nednguyen, 2016/11/07 14:26:24]

Done.

+      upload_test_results.main([
+        '--test-type=foo',
+        '--input-json=%s' % input_json_file_path,
+        '--results-directory=%s' % result_directory,
+        '--test-results-server=foo',
+        '--master-name=sauron',
+      ])
+      files = [(os.path.basename(input_json_file_path), input_json_file_path)]
+      uploader_mock.assert_called_with(
+          'foo',
+          [('builder', 'DUMMY_BUILDER_NAME'),
+           ('testtype', 'foo'),
+           ('master', 'sauron')], files, 120)
+    finally:
+      shutil.rmtree(result_directory)
+
 
+
 if __name__ == '__main__':
   unittest.main()