[tests] Change CodeStubAssemblerTester code type to BUILTIN

[tests] Change CodeStubAssemblerTester code type to BUILTIN

Drive-by-fix 1: be more precise in machine representations for
AllocateNameDictionary to make --turbo_verify_machine_graph happy.

Drive-by-fix 2: Improve graph verifier output by printing input
representation.

BUG=

Committed: https://crrev.com/072ea0c83622a2227e53c047b941429009ec61f4
Cr-Commit-Position: refs/heads/master@{#40797}

[Camillo Bruni, 2016-11-04 10:35:33]

Description was changed from

==========
[tests] Change CodeStubAssemblerTester code type to BUILTIN

Drive-by-fix: reverse comment layout of frame type description to match
stack print order in gdb, avoiding mental meltdown.

BUG=
==========

to

==========
[tests] Change CodeStubAssemblerTester code type to BUILTIN

Drive-by-fix 1: be more precise in machine representations for
AllocateNameDictionary to make --turbo_verify_machine_graph happy.

Drive-by-fix 2: reverse comment layout of frame type description to match
stack print order in gdb, avoiding mental meltdown.

Drive-by-fix 3: Improve graph verifier output by printing input
representation.


BUG=
==========

[Camillo Bruni, 2016-11-04 10:35:33]

cbruni@chromium.org changed reviewers:
+ jarin@chromium.org

[Camillo Bruni, 2016-11-04 10:39:47]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 10:39:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 11:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 11:05:33]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-11-07 08:27:32]

PTAL

[Jarin, 2016-11-07 08:37:35]

Please, do not change frames.h.

Otherwise, lgtm.

[Camillo Bruni, 2016-11-07 08:51:21]

On 2016/11/07 at 08:37:35, jarin wrote:
> Please, do not change frames.h.
> 
> Otherwise, lgtm.

Humm ok, it's just super confusing when looking at the output in gdb.
Essentially there are two issues: 
  1. gdb prints the addresses low to high
  2. the offsets in the comments are going the other way around (e.g. 2+cp vs
-2-cp)
I know I will run into this again in a future debug session since I don't spend
enough time around this part of the code :P. Could you think of another way on
how
to improve the documentation here?

[Camillo Bruni, 2016-11-07 08:51:33]

Description was changed from

==========
[tests] Change CodeStubAssemblerTester code type to BUILTIN

Drive-by-fix 1: be more precise in machine representations for
AllocateNameDictionary to make --turbo_verify_machine_graph happy.

Drive-by-fix 2: reverse comment layout of frame type description to match
stack print order in gdb, avoiding mental meltdown.

Drive-by-fix 3: Improve graph verifier output by printing input
representation.


BUG=
==========

to

==========
[tests] Change CodeStubAssemblerTester code type to BUILTIN

Drive-by-fix 1: be more precise in machine representations for
AllocateNameDictionary to make --turbo_verify_machine_graph happy.

Drive-by-fix 2: Improve graph verifier output by printing input
representation.


BUG=
==========

[Camillo Bruni, 2016-11-07 10:37:55]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-11-07 10:37:56]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2475913002/#ps20001
(title: "reverting documentation changes")

[commit-bot: I haz the power, 2016-11-07 10:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 11:02:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:24:23]

Description was changed from

==========
[tests] Change CodeStubAssemblerTester code type to BUILTIN

Drive-by-fix 1: be more precise in machine representations for
AllocateNameDictionary to make --turbo_verify_machine_graph happy.

Drive-by-fix 2: Improve graph verifier output by printing input
representation.


BUG=
==========

to

==========
[tests] Change CodeStubAssemblerTester code type to BUILTIN

Drive-by-fix 1: be more precise in machine representations for
AllocateNameDictionary to make --turbo_verify_machine_graph happy.

Drive-by-fix 2: Improve graph verifier output by printing input
representation.

BUG=

Committed: https://crrev.com/072ea0c83622a2227e53c047b941429009ec61f4
Cr-Commit-Position: refs/heads/master@{#40797}
==========

[commit-bot: I haz the power, 2016-11-17 22:24:24]

Patchset 2 (id:??) landed as
https://crrev.com/072ea0c83622a2227e53c047b941429009ec61f4
Cr-Commit-Position: refs/heads/master@{#40797}