Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/compiler/machine-graph-verifier.cc

Issue 2475913002: [tests] Change CodeStubAssemblerTester code type to BUILTIN (Closed)
Patch Set: reverting documentation changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | test/cctest/compiler/code-assembler-tester.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/machine-graph-verifier.cc
diff --git a/src/compiler/machine-graph-verifier.cc b/src/compiler/machine-graph-verifier.cc
index 803d8657dd809f8331bec4d65460887b1b9473c2..a8f7a25e1f4a5b79602f630e6e4b8c556bd0ca24 100644
--- a/src/compiler/machine-graph-verifier.cc
+++ b/src/compiler/machine-graph-verifier.cc
@@ -446,12 +446,14 @@ class MachineRepresentationChecker {
void CheckValueInputRepresentationIs(Node const* node, int index,
MachineRepresentation representation) {
Node const* input = node->InputAt(index);
- if (inferrer_->GetRepresentation(input) != representation) {
+ MachineRepresentation input_representation =
+ inferrer_->GetRepresentation(input);
+ if (input_representation != representation) {
std::stringstream str;
- str << "TypeError: node #" << node->id() << ":" << *node->op()
- << " uses node #" << input->id() << ":" << *input->op()
- << " which doesn't have a " << MachineReprToString(representation)
- << " representation.";
+ str << "TypeError: node #" << node->id() << ":" << *node->op() << ":"
+ << MachineReprToString(input_representation) << " uses node #"
+ << input->id() << ":" << *input->op() << " which doesn't have a "
+ << MachineReprToString(representation) << " representation.";
FATAL(str.str().c_str());
}
}
@@ -520,7 +522,9 @@ class MachineRepresentationChecker {
void CheckValueInputForInt64Op(Node const* node, int index) {
Node const* input = node->InputAt(index);
- switch (inferrer_->GetRepresentation(input)) {
+ MachineRepresentation input_representation =
+ inferrer_->GetRepresentation(input);
+ switch (input_representation) {
case MachineRepresentation::kWord64:
return;
case MachineRepresentation::kNone: {
@@ -535,9 +539,9 @@ class MachineRepresentationChecker {
break;
}
std::ostringstream str;
- str << "TypeError: node #" << node->id() << ":" << *node->op()
- << " uses node #" << input->id() << ":" << *input->op()
- << " which doesn't have a kWord64 representation.";
+ str << "TypeError: node #" << node->id() << ":" << *node->op() << ":"
+ << input_representation << " uses node #" << input->id() << ":"
+ << *input->op() << " which doesn't have a kWord64 representation.";
FATAL(str.str().c_str());
}
« no previous file with comments | « src/code-stub-assembler.cc ('k') | test/cctest/compiler/code-assembler-tester.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698