Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration()

Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration()

Removes a path where it might not have taken ownership of an object,
at the expense of making callers check first.  This eases making
the second argument an unique_ptr someday.

Committed: https://pdfium.googlesource.com/pdfium/+/761eed284e1248f851fbb23beaa45835b644ecee

[Tom Sepez, 2016-11-03 23:38:00]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 23:38:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-03 23:38:50]

Description was changed from

==========
Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration()

Removes a path where it might not have taken ownership of an object,
at the expense of making callers check first.
==========

to

==========
Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration()

Removes a path where it might not have taken ownership of an object,
at the expense of making callers check first.  This eases making
the second argument an unique_ptr someday.
==========

[Tom Sepez, 2016-11-03 23:38:50]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-11-03 23:39:11]

Lei, for review.

[commit-bot: I haz the power, 2016-11-03 23:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:53:51]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-04 00:16:39]

lgtm

https://codereview.chromium.org/2475823002/diff/1/core/fpdfapi/parser/cpdf_pa...
File core/fpdfapi/parser/cpdf_parser.cpp (right):

https://codereview.chromium.org/2475823002/diff/1/core/fpdfapi/parser/cpdf_pa...
core/fpdfapi/parser/cpdf_parser.cpp:970: if (pRootDict && pRootDict->GetObjNum()
== pObject->m_ObjNum)
Use |objnum| here as well?

[Tom Sepez, 2016-11-04 17:47:15]

https://codereview.chromium.org/2475823002/diff/1/core/fpdfapi/parser/cpdf_pa...
File core/fpdfapi/parser/cpdf_parser.cpp (right):

https://codereview.chromium.org/2475823002/diff/1/core/fpdfapi/parser/cpdf_pa...
core/fpdfapi/parser/cpdf_parser.cpp:970: if (pRootDict && pRootDict->GetObjNum()
== pObject->m_ObjNum)
On 2016/11/04 00:16:38, Lei Zhang wrote:
> Use |objnum| here as well?

Done.

[Tom Sepez, 2016-11-04 17:47:18]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-11-04 17:47:19]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2475823002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2016-11-04 17:47:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 18:03:02]

Description was changed from

==========
Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration()

Removes a path where it might not have taken ownership of an object,
at the expense of making callers check first.  This eases making
the second argument an unique_ptr someday.
==========

to

==========
Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration()

Removes a path where it might not have taken ownership of an object,
at the expense of making callers check first.  This eases making
the second argument an unique_ptr someday.

Committed:
https://pdfium.googlesource.com/pdfium/+/761eed284e1248f851fbb23beaa45835b644...
==========

[commit-bot: I haz the power, 2016-11-04 18:03:02]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/761eed284e1248f851fbb23beaa45835b644...