core/fpdfapi/parser/cpdf_indirect_object_holder.cpp - Issue 2475823002: Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_indirect_object_holder.cpp

Issue 2475823002: Assert objnum non-zero in ReplaceIndirectObjectIfHigherGeneration() (Closed)

Patch Set: nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_indirect_object_holder.cpp

diff --git a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp

index 6e549de5a7d069e7b79da6b6c11bad1c6b0a0cd5..942754339668fafc784af9d8dcbe507ab90f5c3e 100644

--- a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp

+++ b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp

@@ -56,7 +56,8 @@ uint32_t CPDF_IndirectObjectHolder::AddIndirectObject(CPDF_Object* pObj) {

bool CPDF_IndirectObjectHolder::ReplaceIndirectObjectIfHigherGeneration(

uint32_t objnum,

CPDF_Object* pObj) {

- if (!objnum || !pObj)

+ ASSERT(objnum);

+ if (!pObj)

return false;

CPDF_Object* pOldObj = GetIndirectObject(objnum);

« no previous file with comments | « core/fpdfapi/parser/cfdf_document.cpp ('k') | core/fpdfapi/parser/cpdf_parser.cpp » ('j') | no next file with comments »