Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2475733002: [wrapper-tracing] Remove uses of EmbedderReachableReferenceReporter (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
haraken, Marcel Hlopko
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Remove uses of EmbedderReachableReferenceReporter Removes all uses of EmbedderReachableReferenceReporter and replaces them with the direct API calls. Note that this breaks wrapper tracing until the V8-side of changes are landed: https://codereview.chromium.org/2474163002/ BUG=chromium:468240 R=haraken@chromium.org, hlopko@chromium.org Committed: https://crrev.com/e12090b89c3d65a23b86ded3879d7b3a42d8a424 Cr-Commit-Position: refs/heads/master@{#429855}

Patch Set 1 #

Patch Set 2 : Remove more dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -36 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 6 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp View 4 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Michael Lippautz
ptal, removing complexity; this temporarily breaks wrapper tracing (runtime, not compilation)
4 years, 1 month ago (2016-11-03 18:32:27 UTC) #2
Marcel Hlopko
lgtm
4 years, 1 month ago (2016-11-03 18:34:58 UTC) #5
haraken
LGTM
4 years, 1 month ago (2016-11-04 01:00:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475733002/20001
4 years, 1 month ago (2016-11-04 07:42:27 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 11:16:11 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 11:18:17 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e12090b89c3d65a23b86ded3879d7b3a42d8a424
Cr-Commit-Position: refs/heads/master@{#429855}

Powered by Google App Engine
This is Rietveld 408576698