Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2475733002: [wrapper-tracing] Remove uses of EmbedderReachableReferenceReporter (Closed)
Patch Set: Remove more dead code Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
index 1211e59580cd1b14f8cc09f6f4176f89ab26de66..1743e3cc2d251b3d72fc88d68a207936eb42e48a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
@@ -13,10 +13,6 @@
namespace blink {
-class NullReporter : public v8::EmbedderReachableReferenceReporter {
- void ReportExternalReference(v8::Value* object) override {}
-};
-
static void preciselyCollectGarbage() {
ThreadState::current()->collectAllGarbage();
}
@@ -45,7 +41,7 @@ TEST(ScriptWrappableVisitorTest, ScriptWrappableVisitorTracesWrappers) {
}
ScriptWrappableVisitor* visitor =
V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();
- visitor->TracePrologue(new NullReporter());
+ visitor->TracePrologue();
DeathAwareScriptWrappable* target = DeathAwareScriptWrappable::create();
DeathAwareScriptWrappable* dependency = DeathAwareScriptWrappable::create();
@@ -346,7 +342,7 @@ TEST(ScriptWrappableVisitorTest, NoWriteBarrierOnUnmarkedContainer) {
V8TestingScope scope;
auto rawVisitor = new InterceptingScriptWrappableVisitor(scope.isolate());
swapInNewVisitor(scope.isolate(), rawVisitor);
- rawVisitor->TracePrologue(new NullReporter());
+ rawVisitor->TracePrologue();
v8::Local<v8::String> str =
v8::String::NewFromUtf8(scope.isolate(), "teststring",
v8::NewStringType::kNormal, sizeof("teststring"))
@@ -368,7 +364,7 @@ TEST(ScriptWrappableVisitorTest, WriteBarrierTriggersOnMarkedContainer) {
V8TestingScope scope;
auto rawVisitor = new InterceptingScriptWrappableVisitor(scope.isolate());
swapInNewVisitor(scope.isolate(), rawVisitor);
- rawVisitor->TracePrologue(new NullReporter());
+ rawVisitor->TracePrologue();
v8::Local<v8::String> str =
v8::String::NewFromUtf8(scope.isolate(), "teststring",
v8::NewStringType::kNormal, sizeof("teststring"))
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698