Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2475673004: net: inline gypi file into BUILD.gn file (Closed)

Created:
4 years, 1 month ago by tfarina
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: inline gypi file into BUILD.gn file Remove net.gypi as it is not necessary to share the list of source files between GYP and GN anymore. BUG=None R=eroman@chromium.org,dpranke@chromium.org

Patch Set 1 #

Patch Set 2 : net_nacl_common_sources #

Patch Set 3 : net_non_nacl_sources #

Patch Set 4 : net_test_sources #

Patch Set 5 : net_linux_test_sources #

Patch Set 6 : net_websockets_test_sources #

Patch Set 7 : mac_ios, file and ftp #

Patch Set 8 : net_websockets_sources #

Patch Set 9 : websockets_test_sources #

Patch Set 10 : test_support_data_sources #

Patch Set 11 : unittests_data_sources #

Patch Set 12 : rm update_net_gypi.py #

Patch Set 13 : rm net.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3296 lines, -3474 lines) Patch
M net/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 12 chunks +3296 lines, -19 lines 0 comments Download
D net/data/update_net_gypi.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -142 lines 0 comments Download
D net/net.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -3313 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
tfarina
4 years, 1 month ago (2016-11-03 22:43:11 UTC) #2
tfarina
Ryan, could you review this while Eric is on vacation?
4 years, 1 month ago (2016-11-03 23:42:02 UTC) #6
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-07 17:38:42 UTC) #9
Ryan Hamilton
NOT LGTM - Doing this inlining makes, but I forgot that we have some QUIC ...
4 years, 1 month ago (2016-11-07 17:45:40 UTC) #11
Buck
Hi, I'm looking into adapting the proto-quic script from net/net.gypi to net/BUILD.gn. However, since it ...
3 years, 11 months ago (2017-01-20 21:52:33 UTC) #12
Buck
On 2017/01/20 21:52:33, Buck wrote: > Hi, I'm looking into adapting the proto-quic script from ...
3 years, 11 months ago (2017-01-21 00:27:55 UTC) #13
tfarina
3 years, 10 months ago (2017-02-13 21:57:20 UTC) #15
Closing this as https://codereview.chromium.org/2641413003/ has landed.

Powered by Google App Engine
This is Rietveld 408576698