Set global proxy internal field count based on the global object template.

Set global proxy internal field count based on the global object template.

BUG=v8:5588
R=jochen@chromium.org

Committed: https://crrev.com/7fede7bb98cf2c76b8f441ef1f5a1cb837af9f93
Cr-Commit-Position: refs/heads/master@{#40755}

[dcheng, 2016-11-04 07:58:57]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 07:59:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-11-04 07:59:17]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org

[dcheng, 2016-11-04 07:59:18]

Hopefully I did this right?

[dcheng, 2016-11-04 08:00:08]

Description was changed from

==========
Set global proxy internal field count based on the global object template.

BUG=
==========

to

==========
Set global proxy internal field count based on the global object template.

BUG=v8:5588
R=jochen@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-11-04 08:06:23]

mostly looks good

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h
File src/objects.h (left):

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h#oldcode8514
src/objects.h:8514: static const int kSize = kHashOffset + kPointerSize;
kHeaderSize would usually not contain any of the data, so I think we should
stick with kSize here

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h#newcode8507
src/objects.h:8507: static int SizeFor(int internal_field_count) {
can you move the body of this method to objects-inl.h please

Also add a DCHECK that internal_field_count is non-negative.

Maybe SizeWithInternalFields() or so would be a better name?

[commit-bot: I haz the power, 2016-11-04 08:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 08:26:01]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-11-04 09:27:19]

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h
File src/objects.h (left):

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h#oldcode8514
src/objects.h:8514: static const int kSize = kHashOffset + kPointerSize;
On 2016/11/04 08:06:23, jochen wrote:
> kHeaderSize would usually not contain any of the data, so I think we should
> stick with kSize here

Done.

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2475433008/diff/20001/src/objects.h#newcode8507
src/objects.h:8507: static int SizeFor(int internal_field_count) {
On 2016/11/04 08:06:23, jochen wrote:
> can you move the body of this method to objects-inl.h please
> 
> Also add a DCHECK that internal_field_count is non-negative.
> 
> Maybe SizeWithInternalFields() or so would be a better name?

Done.

[dcheng, 2016-11-04 09:27:42]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 09:27:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-11-04 09:28:12]

lgtm

[commit-bot: I haz the power, 2016-11-04 09:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 09:59:06]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-11-04 09:59:52]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-11-04 09:59:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 10:02:08]

Description was changed from

==========
Set global proxy internal field count based on the global object template.

BUG=v8:5588
R=jochen@chromium.org
==========

to

==========
Set global proxy internal field count based on the global object template.

BUG=v8:5588
R=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-11-04 10:02:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:22:17]

Description was changed from

==========
Set global proxy internal field count based on the global object template.

BUG=v8:5588
R=jochen@chromium.org
==========

to

==========
Set global proxy internal field count based on the global object template.

BUG=v8:5588
R=jochen@chromium.org

Committed: https://crrev.com/7fede7bb98cf2c76b8f441ef1f5a1cb837af9f93
Cr-Commit-Position: refs/heads/master@{#40755}
==========

[commit-bot: I haz the power, 2016-11-17 22:22:18]

Patchset 3 (id:??) landed as
https://crrev.com/7fede7bb98cf2c76b8f441ef1f5a1cb837af9f93
Cr-Commit-Position: refs/heads/master@{#40755}