Set global proxy internal field count based on the global object template.

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 8486 matching lines @@
   // It is null value if this object is not used by any context.
   DECL_ACCESSORS(native_context, Object)
 
   // [hash]: The hash code property (undefined if not initialized yet).
   DECL_ACCESSORS(hash, Object)
 
   DECLARE_CAST(JSGlobalProxy)
 
   inline bool IsDetachedFrom(JSGlobalObject* global) const;
 
+  static int SizeFor(int internal_field_count) {

[jochen (gone - plz use gerrit), 2016/11/04 08:06:23]

can you move the body of this method to objects-inl.h please

Also add a DCHECK that internal_field_count is non-negative.

Maybe SizeWithInternalFields() or so would be a better name?

[dcheng, 2016/11/04 09:27:19]

Done.

+    return kHeaderSize + internal_field_count * kPointerSize;
+  }
+
   // Dispatched behavior.
   DECLARE_PRINTER(JSGlobalProxy)
   DECLARE_VERIFIER(JSGlobalProxy)
 
   // Layout description.
   static const int kNativeContextOffset = JSObject::kHeaderSize;
   static const int kHashOffset = kNativeContextOffset + kPointerSize;
-  static const int kSize = kHashOffset + kPointerSize;

[jochen (gone - plz use gerrit), 2016/11/04 08:06:23]

kHeaderSize would usually not contain any of the data, so I think we should
stick with kSize here

[dcheng, 2016/11/04 09:27:19]

Done.

-  static const int kSizeWithInternalFields =
-      kSize + v8::Context::kProxyInternalFieldCount * kPointerSize;
+  static const int kHeaderSize = kHashOffset + kPointerSize;
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(JSGlobalProxy);
 };
 
 
 // JavaScript global object.
 class JSGlobalObject : public JSObject {
  public:
   // [native context]: the natives corresponding to this global object.
@@ skipping 3242 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_